From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6A14A49F192 for ; Thu, 11 Mar 2010 05:00:34 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.514 X-Spam-Level: X-Spam-Status: No, score=-1.514 tagged_above=-999 required=5 tests=[AWL=-0.404, BAYES_05=-1.11] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OqFZHfDTmtRj for ; Thu, 11 Mar 2010 05:00:32 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 774414916B2 for ; Thu, 11 Mar 2010 05:00:32 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id D3BC619F35F8; Thu, 11 Mar 2010 14:00:13 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id n2-OyK7Yuny7; Thu, 11 Mar 2010 14:00:08 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id AEB6719F35EE; Thu, 11 Mar 2010 14:00:08 +0100 (CET) Received: from steelpick.localdomain (k335-30.felk.cvut.cz [147.32.86.30]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id 9E8B3FA003; Thu, 11 Mar 2010 14:00:08 +0100 (CET) Received: from wsh by steelpick.localdomain with local (Exim 4.71) (envelope-from ) id 1Nphzk-00074j-Fv; Thu, 11 Mar 2010 14:00:08 +0100 From: Michal Sojka To: James Vasile , notmuch@notmuchmail.org In-Reply-To: <87aauhp9kk.fsf@hackervisions.org> References: <87aauhp9kk.fsf@hackervisions.org> Date: Thu, 11 Mar 2010 14:00:08 +0100 Message-ID: <87pr3bm2sn.fsf@steelpick.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [PATCH] Change From and Bcc when creating reply draft buffer X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 13:00:34 -0000 Hi James, On Tue, 09 Mar 2010, James Vasile wrote: > When notmuch creates a reply buffer, it guesses the From and Bcc > addresses. The client is in a better position to guess these, and this > patch adjusts notmuch-reply accordingly. > > diff --git a/notmuch.el b/notmuch.el > index ab56f48..07f957e 100644 > --- a/notmuch.el > +++ b/notmuch.el > @@ -436,10 +436,20 @@ buffer." > (message "Done")) > > (defun notmuch-reply (query-string) > + "Prepare a reply draft buffer. > + > +Have notmuch create a reply buffer, then adjust the from and bcc > +headers to match our current user-full-name and > +user-mail-address." > (switch-to-buffer (generate-new-buffer "notmuch-draft")) > (call-process notmuch-command nil t nil "reply" query-string) > (message-insert-signature) > (goto-char (point-min)) > + (kill-line) > + (insert (format "From: %s <%s>" user-full-name user-mail-address)) Notmuch reply contains From: address which is based on the addresses in .notmuch-config and the replied message. When you use multiple addresses (e.g. home and work address), notmuch puts there the one used in the replied message. It seems that your patch would break this feature. -Michal