From: Michal Sojka <sojkam1@fel.cvut.cz>
To: meskio@sindominio.net, notmuch@notmuchmail.org
Subject: Re: [PATCH] Including 'unread' tag to mails without maildir flags
Date: Sun, 21 Nov 2010 00:26:31 +0100 [thread overview]
Message-ID: <87pqtzk254.fsf@wsheee.2x.cz> (raw)
In-Reply-To: <1290181264-5900-1-git-send-email-meskio@sindominio.net>
On Fri, 19 Nov 2010, meskio@sindominio.net wrote:
> Some mail fetchers, like fetchmail, leaves the email without ':2,' at the end of
> the filename. Notmuch didn't detect this emails as maildir, it didn't add the
> maildir flags to them.
>
> Now it detects if a mail is in a maildir by the directory structure, and add its
> maildir flags correctly.
Hi Ruben,
your patch fixes the problem, but it also breaks one of the tests in
test suite. I created the test for your patch and attempted to fix the
broken test. See the replies to this message.
-Michal
next prev parent reply other threads:[~2010-11-20 23:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 13:04 Maildir-flags synchronization now on master branch Carl Worth
2010-11-11 14:11 ` Kristoffer Ström
2010-11-11 22:38 ` Carl Worth
2010-11-12 0:43 ` Carl Worth
2010-11-12 1:43 ` Dirk Hohndel
2010-11-18 15:37 ` Ruben Pollan
2010-11-19 15:41 ` [PATCH] Including 'unread' tag to mails without maildir flags meskio
2010-11-20 23:26 ` Michal Sojka [this message]
2010-11-20 23:27 ` [PATCH 1/2] test: Add test for messages without maildir info in new Michal Sojka
2010-11-20 23:27 ` [PATCH 2/2] Include 'unread' tag only to mails " Michal Sojka
2010-11-22 10:43 ` Ruben Pollan
2010-11-20 23:54 ` [PATCH] Additional maildir-sync test Michal Sojka
2010-11-22 10:41 ` Ruben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqtzk254.fsf@wsheee.2x.cz \
--to=sojkam1@fel.cvut.cz \
--cc=meskio@sindominio.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).