On Thu, 26 May 2011 17:06:50 +0100, Mark Walters <markwalters1009@gmail.com> wrote:
> These patches implement a reply to sender function.
> On the command line this is done via a new format
> "--format=one" to notmuch reply.
> In emacs it is bound to the key R

I like the feature (at the emacs level). Doing this with "--format=one"
isn't correct though. This new functionality should be orthogonal to
format, (for example, one might want --format=headers-only and still
reply only to the sender).

How about:

	--reply-to=sender
vs.
	--reply-to=all	# Which would be the default

Also, the patch should update the documentation for "notmuch reply",
(both in notmuch.c and notmuch.1).

> I have been running a similar patch set for some time but 
> only tidied it up today. It compiles and works for me.

Thanks for sharing this.

> This is my first submission to the project so I hope that I
> have done everything right.

Perfectly. Keep up the good work.

> Signed-off-by: Mark Walters <markwalters1009@gmail.com>

We don't actually require signed-off-by lines in the notmuch project. I
know the notmuchmail.org website currently points to the git project's
patch submission guidelines. We should really write our own such
guidelines, (which would be dramatically simpler than those from the git
project).

-Carl

-- 
carl.d.worth@intel.com