From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D9F94431FD0 for ; Tue, 5 Jul 2011 01:25:05 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K4bgJrjeGjwS for ; Tue, 5 Jul 2011 01:25:05 -0700 (PDT) Received: from mail-fx0-f46.google.com (mail-fx0-f46.google.com [209.85.161.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B6722431FB6 for ; Tue, 5 Jul 2011 01:25:04 -0700 (PDT) Received: by fxh19 with SMTP id 19so5822435fxh.19 for ; Tue, 05 Jul 2011 01:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=2l2lgg+WbGKsA/wUrk+/blbFMIHvFmaOiOMTBDr1UkM=; b=OSKaelQKIPPeBNz6akRkUf1pybBu/Ny68qrMNGpd7njEgi4S7YaDz25xDu9gqWqnpH d9zmDt/5EDHO0X3jB2pLHug57Z8sDXUPDyVoC5RhXlBBmd+HrBWzgKuVWrV8Jd6ICpIE kGWA+pjP7SLH2moeaa7aLF7xISM9s1hkNOkHI= Received: by 10.223.158.72 with SMTP id e8mr10726435fax.39.1309854303279; Tue, 05 Jul 2011 01:25:03 -0700 (PDT) Received: from localhost (s1132.dyn.hrz.tu-darmstadt.de [130.83.108.108]) by mx.google.com with ESMTPS id o23sm5114048faa.9.2011.07.05.01.25.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Jul 2011 01:25:01 -0700 (PDT) From: Daniel Schoepe To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] emacs: User-defined sections in notmuch-hello In-Reply-To: <87wrfxk34u.fsf@steelpick.2x.cz> References: <1309379221-5617-1-git-send-email-daniel.schoepe@googlemail.com> <87wrfxk34u.fsf@steelpick.2x.cz> User-Agent: Notmuch/0.5-321-g0ef06a2 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Tue, 05 Jul 2011 10:24:53 +0200 Message-ID: <87pqlpjfsa.fsf@tredergarh.home.box> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2011 08:25:06 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 05 Jul 2011 02:00:33 +0200, Michal Sojka wrot= e: > First, the customization interface for the custom sections (not the > predefined ones) is very confusing. I was not able to use it at all. > Instead I hacked the source code (see below) to add my section to the > notmuch-hello-sections list. What specifically did you find confusing? The first customization-option is intended for sections like the all tags section which various configuration options which should be explained by the docstrings next to the options. The second item allows saved-searches-like sections. By the way: Instead of editing the source directly, you can also put all customizations like that in your configuration files and set notmuch-hello-sections from there. Nevertheless your inbox-display functions look useful in general so they should indeed be included. > Second, when I tried to understand your patch, I found some names of > functions and variables quite confusing. In the patch below, I tried to > give them a better names and I also updated the documentation. Feel free > to use my changes for your later patch submission. Thanks, those look quite a bit clearer, naming things like that is really not my strong suit. I'll include them in the next version of the patch. >=20 > And last but not least, you allow quite wild modifications of tag > searches (e.g. in notmuch-hello-generate-tag-alist), but is might be > also useful to use such modifications for other searches. For example, I > want to modify the saved searches in a similar way. >=20=20 Are you referring to things like specifying a filter for each tag or count in saved-searches? My thinking was that since you specify each item manually anyway, you can append any filter you might want to use there. But I guess you're right that it's a bit more convenient to be able to specify those once and not having to repeat it for each item. > And here are my changes to your patch, which you might use as a > suggestions for a next version of your patch. As I wrote above, it > renames some functions and variables to more understandable names, > updates documentation and adds a custom section for my personal use (I > can live with this custom section in my .emacs if others do not like > it). If we add the same configuration options that notmuch-hello-generate-tag-alist accepts, this section should be easy to specify in your ~/.emacs with one or two lines anyway. Cheers, Daniel --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOEspVAAoJEIaTAtce+Z+JyfUQAIcQOA9FUWB90uOWBXwP970/ Huh0w7NfjVIwP02vBjSt+Z0N4sylqpLCeBxF1YA7xvum5zLqvPZAaMSHE9rwhi0m F4wsb67FzGOTWo7c1zMv/DmheOvgQ669yc3juQWaldRebij5pRCjj8AUcpd2PEXj WYNYGamk3WVOTzs0gETC7UKtOmS8ORhkK67UBw80UhinUiT65xJv1TnHLZzfrJMQ YBheW4UqSNQsGllEzcGiei7pXffqBL0PYwKNCXHLTaiK3GK/7saaXc+d/G9V1lod acDMlzpuLPU7I5MgsHcKaZ1Tw2fZuH7/4GCNOPXZbDjTmDPzHiTMLFLvRqh/+SGz r0FnuDHr8D0QATM6dgkkfjwn411JMndLFOItxfGF86bpxN/YMJxCDB2l5ODwk5nH 3mcWPnIKs16+UbHiVA6VYAhldZdsBiFghKWogbRc//derVEr4n4/E4gNkPBluzhr 1Yd45gZNIADHd/Sjb40wF1BqgfKKpxkMDW/9Mn8EexClKAKldbeIRAiPdUH5sQDT TXPm2RZmzybb+6XjdYeHHzyxNCyoV6nBrmHmJsBnkM8F2h8W6g7W6gUIN9SQtxEu dA6N6uI4bqa9fkctF3PEBAR5n7z36LeCmQu1KtjbnGgRdpxOolszkh6n7Qxtx6rg Wj+mtwE4AJIph4g1qVkD =hAeS -----END PGP SIGNATURE----- --=-=-=--