From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 96333431FB6 for ; Wed, 16 Nov 2011 02:58:02 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I99Y-2kTXp0B for ; Wed, 16 Nov 2011 02:58:01 -0800 (PST) Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id ACAA3429E26 for ; Wed, 16 Nov 2011 02:58:01 -0800 (PST) Received: by wyg19 with SMTP id 19so335416wyg.26 for ; Wed, 16 Nov 2011 02:57:59 -0800 (PST) Received: by 10.180.81.73 with SMTP id y9mr34883441wix.37.1321441079192; Wed, 16 Nov 2011 02:57:59 -0800 (PST) Received: from localhost ([109.131.148.49]) by mx.google.com with ESMTPS id v6sm16106432wix.1.2011.11.16.02.57.57 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Nov 2011 02:57:57 -0800 (PST) From: Pieter Praet To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: notmuch-hello: respect notmuch-help's wishes In-Reply-To: <87zkg2a7pd.fsf@rocinante.cs.unb.ca> References: <87ei522v4t.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me> <87zkg2a7pd.fsf@rocinante.cs.unb.ca> User-Agent: Notmuch/0.9+76~g2fd88e6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Wed, 16 Nov 2011 11:56:59 +0100 Message-ID: <87pqgsfi84.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2011 10:58:02 -0000 On Fri, 11 Nov 2011 12:29:34 -0500, David Bremner wrote: > On Sat, 16 Apr 2011 15:12:43 +0200, Pieter Praet wrote: > > Calling notmuch-help in notmuch-hello-mode results in error > > "apply: Wrong type argument: listp, keymap" > > Hi Pieter; > > I'm a little confused here. I still get the same error after applying > your patch. Is there a followup patch I missed? > Hmm, it works here... I've tried cooking up a proper test: #+begin_src sh test_begin_subtest "Help in notmuch-hello" test_emacs '(let ((major-mode '\''notmuch-hello-mode)) (notmuch-help) (test-output))' cat <EXPECTED Placeholder for actual expected output... EOF test_expect_equal_file OUTPUT EXPECTED #+end_src ... but I'm making some stupid mistake, because it doesn't output *anything*, not even for `notmuch-search-mode' and `notmuch-show-mode'. It works when running Emacs like this, though: #+begin_src sh emacs --no-init-file --eval '(progn (add-to-list '\''load-path (concat (getenv "HOME") "/src/dev/notmuch/emacs")) (require '\''notmuch) (notmuch-hello) (notmuch-help))' #+end_src Anyways, it's a rather lame patch (even more so when taking my horrible typo into consideraton) so I wouldn't waste too much time on it if I were you. Duplication is evil, so this bug should be fixed in `notmuch-substitute-one-command-key-with-prefix' instead. > David Peace -- Pieter