From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
Date: Wed, 01 Feb 2012 13:19:31 +0400 [thread overview]
Message-ID: <87pqdync64.fsf@gmail.com> (raw)
In-Reply-To: <87r4yfszx9.fsf@servo.finestructure.net>
On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Wed, 1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > The down side of this approach is that diff argument order depends on
> > test_expect_equal_file() argument order. So sometimes we get diff
> > from expected to actual results, and sometimes the other way around.
> > But the files are always named correctly.
>
> Actually, I think this last point is the most important thing to retain.
> Consistency in the diffs makes reading test results much more efficient.
> The order I don't much care about. But seeing as we have been
> consistent with a particular order for a while, it seems like more
> effort than it's worth to change it.
>
It is not true that we are consistent with test_expect_equal_file()
argument order. If we were, I would not bother. The problem is we are
not. I remember that we already fixed argument order for
test_expect_equal() and/or test_expect_equal_file(). If we do not solve
this problem, we should make it a tradition.
Consistent diff would be good. But IMO the current situation is worse:
we are *supposed* to have consistent diff output, but in reality we have
messed diff output.
Also please consider the following points:
* Usually one is looking at a single failing test. So it is not like
you have a series of inconsistent diffs.
* I personally can not remember the argument and diff order. So each
time I need to understand the diff, I look at the beginning to see
which side is where anyway.
So IMHO diff order is not that important. But I would like to see a
better solution. Perhaps Tomi's proposal would be the one.
Regards,
Dmitry
> jamie.
next prev parent reply other threads:[~2012-02-01 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 7:19 [PATCH] test: make test_expect_equal_file() arguments flexible Dmitry Kurochkin
2012-02-01 8:12 ` David Edmondson
2012-02-01 8:47 ` Jameson Graef Rollins
2012-02-01 8:55 ` Tomi Ollila
2012-02-01 9:23 ` Dmitry Kurochkin
2012-02-01 9:19 ` Dmitry Kurochkin [this message]
2012-02-01 10:18 ` Tomi Ollila
2012-02-01 10:37 ` Dmitry Kurochkin
2012-02-01 17:24 ` Jameson Graef Rollins
2012-02-01 23:42 ` Dmitry Kurochkin
2012-02-02 0:07 ` Dmitry Kurochkin
2012-02-02 14:33 ` David Edmondson
2012-02-02 15:25 ` Tomi Ollila
2012-02-02 17:40 ` Jameson Graef Rollins
2012-09-02 2:38 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqdync64.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).