From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations
Date: Sat, 24 Mar 2012 14:58:43 -0400 [thread overview]
Message-ID: <87pqc1ygf0.fsf@rocinante.cs.unb.ca> (raw)
In-Reply-To: <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>
On Sat, 24 Mar 2012 18:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:
> + if (argv[i][0] == '+' || argv[i][0] == '-') {
> + tag_ops[tag_ops_count++] = (tag_operation_t) {
> + .tag = argv[i] + 1,
> + .remove = argv[i][0] == '-',
> + };
I'm not sure if this is a worthwhile use of a C99. Wouldn't it be
simpler to just use two assignments? and maybe increment the index
after? Still 3 lines of code.
Other than that, this patch looked ok to me. I think it probably
deserves a NEWS patch that the ordering behaviour changed. I do think
the new order is more sensible, and the old one was never documented.
d
next prev parent reply other threads:[~2012-03-26 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 16:14 [PATCH 0/3] cli: notmuch tag/restore refactoring Jani Nikula
2012-03-24 16:14 ` [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations Jani Nikula
2012-03-24 18:58 ` David Bremner [this message]
2012-03-25 11:24 ` David Bremner
2012-03-24 16:14 ` [PATCH 2/3] cli: refactor "notmuch tag" query tagging into a separate function Jani Nikula
2012-03-24 16:14 ` [PATCH 3/3] cli: refactor "notmuch restore" message " Jani Nikula
2012-03-25 13:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqc1ygf0.fsf@rocinante.cs.unb.ca \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).