From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8BA19431FAF for ; Tue, 24 Apr 2012 19:28:38 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PkCipRpuv1VN for ; Tue, 24 Apr 2012 19:28:36 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 72A9B431FAE for ; Tue, 24 Apr 2012 19:28:36 -0700 (PDT) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SMry4-0000Ci-42; Tue, 24 Apr 2012 23:28:32 -0300 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1SMrxy-000599-IS; Tue, 24 Apr 2012 23:28:26 -0300 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v3 1/4] new: Consistently treat fatal errors as fatal In-Reply-To: <1335109852-10150-2-git-send-email-amdragon@mit.edu> References: <1330357759-1337-1-git-send-email-amdragon@mit.edu> <1335109852-10150-1-git-send-email-amdragon@mit.edu> <1335109852-10150-2-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Tue, 24 Apr 2012 23:28:26 -0300 Message-ID: <87pqawwnn9.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2012 02:28:38 -0000 Austin Clements writes: > Previously, fatal errors in add_files_recursive were not treated as > fatal by its callers (including itself!). This makes > add_files_recursive errors consistently fatal and updates all callers > to treat them as fatal. series pushed. d