From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E12A3431FAF for ; Thu, 29 Nov 2012 16:17:17 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 97jdFiVXUFVu for ; Thu, 29 Nov 2012 16:17:17 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7C41A431FAE for ; Thu, 29 Nov 2012 16:17:17 -0800 (PST) Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.167.90.129] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TeEI7-0002bL-U4; Thu, 29 Nov 2012 20:17:16 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TeEI2-0006RW-Co; Thu, 29 Nov 2012 20:17:10 -0400 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines In-Reply-To: <87vcctiauq.fsf@qmul.ac.uk> References: <1353792017-31459-1-git-send-email-david@tethera.net> <1353792017-31459-10-git-send-email-david@tethera.net> <87vcctiauq.fsf@qmul.ac.uk> User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Thu, 29 Nov 2012 20:17:10 -0400 Message-ID: <87pq2wgd15.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2012 00:17:18 -0000 Mark Walters writes: > I don't know how freeze/thaw work but does it matter that you don't thaw > when there is an error? My interpretation is that by not thawing before we destroy the message, we are aborting the transaction, since the freeze/thaw information is stored in the message structure. It is documented as forbidden to call thaw _more_ times than freeze, but less is not explicitely mentioned. >> + >> +/* >> + * Add a tag operation (delete iff remote == TRUE) to a list. >> + * The list is expanded as necessary. >> + */ > > Typo s/remote/remove/ fixed in local git. >> + >> +/* >> + * Apply a list of tag operations, in order to a message. > > I found the comment awkward to parse: as "in order to " Re-punctu-worded to "Apply a list of tag operations, in order, to a given message"