From: Jani Nikula <jani@nikula.org>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH 1/1] devel/STYLE: information how to enable standard pre-commit hook
Date: Tue, 26 Mar 2013 10:18:11 +0100 [thread overview]
Message-ID: <87ppymfrjg.fsf@nikula.org> (raw)
In-Reply-To: <1364040435-22357-1-git-send-email-tomi.ollila@iki.fi>
On Sat, 23 Mar 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> It is easier to enable git standard pre-commit hook, when the
> operation to do so is presented.
> ---
> devel/STYLE | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/devel/STYLE b/devel/STYLE
> index 0792ba1..92de42c 100644
> --- a/devel/STYLE
> +++ b/devel/STYLE
> @@ -45,8 +45,9 @@ function (param_type param, param_type param)
> - likewise, there is a space following keywords such as if and while
> - every binary operator should have space on either side.
>
> -* No trailing whitespace. Please enable the standard pre-commit hook
> - in git (or an equivalent hook).
> +* No trailing whitespace. Please enable the standard pre-commit hook in git
> + (or an equivalent hook). The standard pre-commit hook is enabled by simply
> + renaming file '.git/hooks/pre-commit.sample' to '.git/hooks/pre-commit' .
<bikeshedding>
Or just refer to http://git-scm.com/book/en/Customizing-Git-Git-Hooks or
man githooks if you really need to. Older versions of git used to have
properly named hooks with the executable bit unset...
Personally I wouldn't ask anyone to enable the hook because I wouldn't
enable it in the first place. There's $EDITOR and 'git diff --check' to
do that kind of thing... When I want to commit I want to commit, warts
and all, and I don't want a hook to prevent me from doing so!
</bikeshedding>
BR,
Jani.
next prev parent reply other threads:[~2013-03-26 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 12:07 [PATCH 1/1] devel/STYLE: information how to enable standard pre-commit hook Tomi Ollila
2013-03-26 9:18 ` Jani Nikula [this message]
2013-03-26 9:30 ` Tomi Ollila
2013-03-29 14:12 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppymfrjg.fsf@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).