From: David Bremner <david@tethera.net>
To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated
Date: Sat, 04 May 2013 11:10:36 -0300 [thread overview]
Message-ID: <87ppx6al9f.fsf@zancas.localnet> (raw)
In-Reply-To: <1362540709-28765-2-git-send-email-aaronecay@gmail.com>
Aaron Ecay <aaronecay@gmail.com> writes:
> + if (ref && strcmp(ref, message_id)) {
> + return ref;
> + } else {
> + return NULL;
> + }
As a nit, there should be a space after strcmp. But if nobody has any
other comments, I could amend that.
d
next prev parent reply other threads:[~2013-05-04 14:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 23:50 [RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated Aaron Ecay
2013-02-26 9:19 ` Jani Nikula
2013-02-26 19:40 ` Aaron Ecay
2013-02-28 19:41 ` Jani Nikula
2013-03-01 17:06 ` Jani Nikula
2013-03-03 23:46 ` Aaron Ecay
2013-03-03 23:55 ` Aaron Ecay
2013-03-04 2:45 ` David Bremner
2013-03-06 3:31 ` [PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers Aaron Ecay
2013-03-06 3:31 ` [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated Aaron Ecay
2013-05-04 14:10 ` David Bremner [this message]
2013-05-04 16:24 ` Jani Nikula
2013-05-14 0:43 ` David Bremner
2013-05-04 14:01 ` [PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers David Bremner
2013-05-04 14:03 ` David Bremner
2013-05-04 16:23 ` Jani Nikula
2013-03-04 5:59 ` [RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppx6al9f.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=aaronecay@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).