[PATCH] emacs: tree: bare-id in tree

[PATCH] emacs: tree: bare-id in tree

[Mark Walters]

Previously notmuch-tree-get-message-id always returned the id
including the prefix "id:". Modify the function to take an optional
`bare' argument saying to return the raw string.

This will be useful later and brings the function in line with
notmuch-show-get-message-id.
---
This functionality will be useful later. I think it reasonable to put
it in now as it does bring notmuch-tree-get-message-id in line with
notmuch-show-get-message-id which already has this option.

Best wishes

Mark


 emacs/notmuch-tree.el |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 8d59e65..1dde9a7 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -319,11 +319,13 @@ correct message properties."
   "Return the tags of the current message."
   (notmuch-tree-get-prop :tags))
 
-(defun notmuch-tree-get-message-id ()
+(defun notmuch-tree-get-message-id (&optional bare)
   "Return the message id of the current message."
   (let ((id (notmuch-tree-get-prop :id)))
     (if id
-	(notmuch-id-to-query id)
+	(if bare
+	    id
+	  (notmuch-id-to-query id))
       nil)))
 
 (defun notmuch-tree-get-match ()
-- 
1.7.9.1

Re: [PATCH] emacs: tree: bare-id in tree

[Tomi Ollila]

On Thu, Dec 19 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously notmuch-tree-get-message-id always returned the id
> including the prefix "id:". Modify the function to take an optional
> `bare' argument saying to return the raw string.
>
> This will be useful later and brings the function in line with
> notmuch-show-get-message-id.
> ---

LGTM.

Tomi


> This functionality will be useful later. I think it reasonable to put
> it in now as it does bring notmuch-tree-get-message-id in line with
> notmuch-show-get-message-id which already has this option.
>
> Best wishes
>
> Mark
>
>
>  emacs/notmuch-tree.el |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 8d59e65..1dde9a7 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -319,11 +319,13 @@ correct message properties."
>    "Return the tags of the current message."
>    (notmuch-tree-get-prop :tags))
>  
> -(defun notmuch-tree-get-message-id ()
> +(defun notmuch-tree-get-message-id (&optional bare)
>    "Return the message id of the current message."
>    (let ((id (notmuch-tree-get-prop :id)))
>      (if id
> -	(notmuch-id-to-query id)
> +	(if bare
> +	    id
> +	  (notmuch-id-to-query id))
>        nil)))
>  
>  (defun notmuch-tree-get-match ()
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: tree: bare-id in tree

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> Previously notmuch-tree-get-message-id always returned the id
> including the prefix "id:". Modify the function to take an optional
> `bare' argument saying to return the raw string.

pushed.

d