From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 178CC431FBD for ; Wed, 9 Jul 2014 16:41:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9pC9eK4dZu0v for ; Wed, 9 Jul 2014 16:41:15 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DFA70431FAF for ; Wed, 9 Jul 2014 16:41:15 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1X51UB-0002N7-45; Wed, 09 Jul 2014 20:41:15 -0300 Received: (nullmailer pid 11406 invoked by uid 1000); Wed, 09 Jul 2014 23:41:11 -0000 From: David Bremner To: Peter Wang , notmuch@notmuchmail.org Subject: Re: [PATCH v2 01/10] lib: add return status to database close and destroy In-Reply-To: <1397653165-15620-2-git-send-email-novalazy@gmail.com> References: <1397653165-15620-1-git-send-email-novalazy@gmail.com> <1397653165-15620-2-git-send-email-novalazy@gmail.com> User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 09 Jul 2014 20:41:11 -0300 Message-ID: <87pphe85ig.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jul 2014 23:41:19 -0000 Peter Wang writes: > From: Jani Nikula > > notmuch_database_close may fail in Xapian ->flush() or ->close(), so > report the status. Similarly for notmuch_database_destroy which calls > close. pushed this one patch, along with a minimal NEWS item.