From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id A2B42431FBF
	for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 06:11:54 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id oZweNMR3lhcv for <notmuch@notmuchmail.org>;
	Sun, 13 Jul 2014 06:11:44 -0700 (PDT)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id D26CC431FBC
	for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 06:11:44 -0700 (PDT)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1X6JZ9-00070G-Kg; Sun, 13 Jul 2014 10:11:43 -0300
Received: (nullmailer pid 7625 invoked by uid 1000); Sun, 13 Jul 2014
	13:11:40 -0000
From: David Bremner <david@tethera.net>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] test: add tests for Ruby bindings
In-Reply-To: <1400841267-12807-4-git-send-email-felipe.contreras@gmail.com>
References: <1400841267-12807-1-git-send-email-felipe.contreras@gmail.com>
	<1400841267-12807-4-git-send-email-felipe.contreras@gmail.com>
User-Agent: Notmuch/0.18.1+29~gb5327d4 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 13 Jul 2014 10:11:40 -0300
Message-ID: <87pph9flo3.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Cc: Ali Polatel <alip@exherbo.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jul 2014 13:11:54 -0000

Felipe Contreras <felipe.contreras@gmail.com> writes:

>  2 files changed, 99 insertions(+)
>  create mode 100755 test/T540-ruby.sh
> +# Copyright (c) 2014 Felipe Contreras

Thanks for writing these; lack of tests bindings has been a long time
irritant for me.  Can you put in a brief license statement as well as
the copyright line?  Something like "same as notmuch" or "GPL 3+" is ok
for me.

>  
> +grep -q "WITH_RUBY = 1" ../Makefile.config && test_set_prereq RUBY

This looks a bit fragile. Somewhere in the patch queue is something to
create a config.sh snippet which would help here.

d