[PATCH 1/2] test: check for debug symbols in notmuch

[PATCH 1/2] test: check for debug symbols in notmuch

[David Bremner]

In the future, tests may rely on debug symbols being present in
notmuch, so we plan to switch the default flags.

The main purpose of this test is to help explain the perhaps
mysterious failures of other tests which rely on symbols being
present.
---
 test/T000-basic.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/T000-basic.sh b/test/T000-basic.sh
index ebbb6d2..bf08f3e 100755
--- a/test/T000-basic.sh
+++ b/test/T000-basic.sh
@@ -91,4 +91,9 @@ test_expect_equal \
     "$(dirname ${TEST_DIRECTORY})" \
     "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"
 
+test_begin_subtest 'notmuch is compiled with debugging symbols'
+test_subtest_known_broken
+readelf --sections $(which notmuch) | grep \.debug
+test_expect_equal 0 $?
+
 test_done
-- 
2.1.0

[PATCH 2/2] configure: add debug flags by default.

[David Bremner]

This makes development (in particular the test suite) easier. Those
concerned about the extra diskspace can override the default or use
strip.
---
 configure          | 2 +-
 test/T000-basic.sh | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/configure b/configure
index 86ba2f7..331f29b 100755
--- a/configure
+++ b/configure
@@ -45,7 +45,7 @@ fi
 # environment variables)
 CC=${CC:-cc}
 CXX=${CXX:-c++}
-CFLAGS=${CFLAGS:--O2}
+CFLAGS=${CFLAGS:--g -O2}
 CPPFLAGS=${CPPFLAGS:-}
 CXXFLAGS=${CXXFLAGS:-\$(CFLAGS)}
 LDFLAGS=${LDFLAGS:-}
diff --git a/test/T000-basic.sh b/test/T000-basic.sh
index bf08f3e..ef64245 100755
--- a/test/T000-basic.sh
+++ b/test/T000-basic.sh
@@ -92,7 +92,6 @@ test_expect_equal \
     "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"
 
 test_begin_subtest 'notmuch is compiled with debugging symbols'
-test_subtest_known_broken
 readelf --sections $(which notmuch) | grep \.debug
 test_expect_equal 0 $?
 
-- 
2.1.0

Re: [PATCH 1/2] test: check for debug symbols in notmuch

[Tomi Ollila]

On Fri, Oct 03 2014, David Bremner <david@tethera.net> wrote:

> In the future, tests may rely on debug symbols being present in
> notmuch, so we plan to switch the default flags.
>
> The main purpose of this test is to help explain the perhaps
> mysterious failures of other tests which rely on symbols being
> present.
> ---

series LGTM.

>  test/T000-basic.sh | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/test/T000-basic.sh b/test/T000-basic.sh
> index ebbb6d2..bf08f3e 100755
> --- a/test/T000-basic.sh
> +++ b/test/T000-basic.sh
> @@ -91,4 +91,9 @@ test_expect_equal \
>      "$(dirname ${TEST_DIRECTORY})" \
>      "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"
>  
> +test_begin_subtest 'notmuch is compiled with debugging symbols'
> +test_subtest_known_broken
> +readelf --sections $(which notmuch) | grep \.debug
> +test_expect_equal 0 $?
> +
>  test_done
> -- 
> 2.1.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] test: check for debug symbols in notmuch

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Fri, Oct 03 2014, David Bremner <david@tethera.net> wrote:
>
>> In the future, tests may rely on debug symbols being present in
>> notmuch, so we plan to switch the default flags.
>>
>> The main purpose of this test is to help explain the perhaps
>> mysterious failures of other tests which rely on symbols being
>> present.
>> ---
>
> series LGTM.
>

Series pushed,

d