From: David Bremner <david@tethera.net>
To: Johannes Schauer <josch@debian.org>, notmuch@notmuchmail.org
Subject: Re: [bug] notmuch requires Content-Disposition mime header value to be lower case
Date: Fri, 18 Sep 2015 09:03:20 -0300 [thread overview]
Message-ID: <87pp1grl2v.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <20150917083956.1941.35098@localhost>
Johannes Schauer <josch@debian.org> writes:
> Funnily though there seem to be some weird newline differences that I cannot
> explain, so I left them for somebody else to fix.
>
Looking at the files (.EXPECTED and .OUTPUT) in test/tmp.T190-multipart,
there's more than whitespace changes. Some things that used to marked
"attachment" in the output are now marked "part".
> diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh
> index 7c4c9f7..f16cc90 100755
> --- a/test/T190-multipart.sh
> +++ b/test/T190-multipart.sh
> @@ -48,7 +48,7 @@ cat embedded_message >> ${MAIL_DIR}/multipart
> cat <<EOF >> ${MAIL_DIR}/multipart
>
> --=-=-=
> -Content-Disposition: attachment; filename=attachment
> +Content-Disposition: ATTACHMENT; FILENAME=attachment
>
> This is a text attachment.
>
> @@ -487,7 +487,7 @@ This is an embedded message, with a multipart/alternative part.
> --==-=-==--
>
> --=-=-=
> -Content-Disposition: attachment; filename=attachment
> +Content-Disposition: ATTACHMENT; FILENAME=attachment
>
> This is a text attachment.
>
I'd recommend making your own new test, rather than modifying existing
ones to test multiple things. I'd also recommend using json / sexp
output for your tests, since the ad-hoc text format is kindof
semi-deprecated.
d
next prev parent reply other threads:[~2015-09-18 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150917070056.1941.94846@localhost>
[not found] ` <20150917083612.1941.22480@localhost>
2015-09-17 8:39 ` [bug] notmuch requires Content-Disposition mime header value to be lower case Johannes Schauer
2015-09-18 12:03 ` David Bremner [this message]
2015-09-18 12:37 ` Johannes Schauer
2015-09-18 13:26 ` David Bremner
2015-09-26 8:59 ` Jani Nikula
2015-09-26 9:35 ` [PATCH 1/2] lib: content disposition values are not case-sensitive Jani Nikula
2015-09-26 9:35 ` [PATCH 2/2] cli: " Jani Nikula
2015-10-06 10:20 ` [WIP] tests: add test for case insensitive Content-Disposition David Bremner
2015-10-18 11:58 ` Jani Nikula
2015-10-18 12:05 ` Johannes Schauer
2015-11-19 11:57 ` [PATCH 1/2] lib: content disposition values are not case-sensitive David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp1grl2v.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=josch@debian.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).