unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH 3/4] emacs: add function to resend message to new recipients
Date: Wed, 28 Oct 2015 08:00:11 +0000	[thread overview]
Message-ID: <87pozza0dw.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1441204482-26509-3-git-send-email-tomi.ollila@iki.fi>


On Wed, 02 Sep 2015, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> The new function notmuch-show-message-resend re-sends
> message to new recipients using #'message-resend.
>
> Recipients are read from minibuffer as a comma-separated
> string (with some keyboard support including tab completion).
>
> Final confirmation before sending is asked.
> ---

This series looks good to me modulo three minor comments  (I even
like the choice of binding to b). 

The first comment is that, in light of the recent address series, I
think Patch 2 can be dropped completely, with a small change to this
patch. See below for that, and the other two minor suggestions.

Also, I wonder if when it gets a NEWS item it might be worth mentioning
that a user might have already added this function to their emacs init
file as it has been on the wiki. (It took me way too long to realise
that was why this patch was not working for me!)

Best wishes

Mark


>
> Since id:1440619626-18768-2-git-send-email-tomi.ollila@iki.fi
>   - changed (bury-buffer) to (notmuch-bury-or-kill-this-buffer)
>     - it is hard to have the buffer been kept around but it is posiible
>
>  emacs/notmuch-address.el | 19 +++++++++++++++++++
>  emacs/notmuch-show.el    |  8 ++++++++
>  2 files changed, 27 insertions(+)
>
> diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
> index 8982a415ce11..83788efd3c1b 100644
> --- a/emacs/notmuch-address.el
> +++ b/emacs/notmuch-address.el
> @@ -119,4 +119,23 @@ (defun notmuch-address-locate-command (command)
>  
>  ;;
>  
> +(defun notmuch-address-from-minibuffer (prompt)
> +  (if (not (notmuch-address--message-insinuated))
> +      (read-string prompt)

This can become 
     (if (not notmuch-address-command)
 
> +    (let ((rmap (copy-keymap minibuffer-local-map))
> +	  (omap minibuffer-local-map))
> +      ;; Configure TAB to start completion when executing read-string.
> +      ;; "Original" minibuffer keymap is restored just before calling
> +      ;; notmuch-address-expand-name as it may also use minibuffer-local-map
> +      ;; (completing-read probably does not but if something else is used there).
> +      (define-key rmap "\C-i" (lambda () ;; TAB

I think this could become (define-key rmap (kbd "TAB") (lambda () ....

which is easy to read and consistent with the definitions of other
keymaps (eg the main notmuch-show keymap).

> +			       (interactive)
> +			       (let ((enable-recursive-minibuffers t)
> +				     (minibuffer-local-map omap))
> +				 (notmuch-address-expand-name))))
> +      (let ((minibuffer-local-map rmap))
> +	(read-string prompt)))))
> +
> +;;
> +
>  (provide 'notmuch-address)
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 0565ab0725b2..046cb0e41f0b 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1806,6 +1806,14 @@ (defun notmuch-show-forward-message (&optional prompt-for-sender)
>    (with-current-notmuch-show-message
>     (notmuch-mua-new-forward-message prompt-for-sender)))
>  
> +(defun notmuch-show-resend-message (addresses)
> +  "Resend the current message."
> +  (interactive (list (notmuch-address-from-minibuffer "Resend to: ")))
> +  (when (yes-or-no-p (concat "Confirm resend to " addresses " "))

Perhaps y-or-n-p rather than yes-or-no-p?
 
> +    (notmuch-show-view-raw-message)
> +    (message-resend addresses)
> +    (notmuch-bury-or-kill-this-buffer)))
> +
>  (defun notmuch-show-next-message (&optional pop-at-end)
>    "Show the next message.
>  
> -- 
> 2.0.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2015-10-28  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 14:34 [PATCH 1/4] emacs: notmuch-show-view-raw-message clears buffer, makes it read-only Tomi Ollila
2015-09-02 14:34 ` [PATCH 2/4] emacs: add function notmuch-address--message-insinuated Tomi Ollila
2015-09-02 14:34 ` [PATCH 3/4] emacs: add function to resend message to new recipients Tomi Ollila
2015-10-28  8:00   ` Mark Walters [this message]
2015-09-02 14:34 ` [PATCH 4/4] emacs: bind notmuch-show-resend-message to 'b' in notmuch-show mode Tomi Ollila
2015-11-23 12:55 ` [PATCH 1/4] emacs: notmuch-show-view-raw-message clears buffer, makes it read-only David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pozza0dw.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).