From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>,
notmuch@notmuchmail.org, notmuch@freelists.org
Subject: Re: [PATCH 1/5] build: add target to run cppcheck
Date: Sun, 27 Aug 2017 11:20:03 +0300 [thread overview]
Message-ID: <87pobhl8wc.fsf@nikula.org> (raw)
In-Reply-To: <20170826144141.11140-2-david@tethera.net>
On Sat, 26 Aug 2017, David Bremner <david@tethera.net> wrote:
> The advantage of having a target as opposed to running cppcheck by
> hand
>
> - reuse list of source files
> - output errors in a format parsable, e.g. by emacs
> - returns exit code 1 on any error, for possibly use in other
> targets.
>
> Things not addressed here
>
> - parallelism. Doing this correctly seems like a rabbit-hole.
>
> - what target to invoke this from. The 8s delay (on my machine) seems
> acceptable, but not necessarily the resulting fragility in
> autobuilders.
Perhaps something could be build around something like below. It
addresses the parallelism, but it's not without problems either. Only
the files that need to be built would get checked; OTOH that may be
beneficial while developing. Clearly we don't want to run cppcheck
unconditionally when it's available. Would it be a configure option that
would not be enabled by default? Or a make variable passed on the
command like, say 'make CPPCHECK=1'?
Food for thought; I'm not opposed to applying the patch at hand either.
BR,
Jani.
diff --git a/Makefile.local b/Makefile.local
index 6a5168f16427..fd59feafcd44 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -191,12 +191,20 @@ endif
# Otherwise, print the full command line.
quiet ?= $($(shell echo $1 | sed -e s'/ .*//'))
+CPPCHECK=cppcheck
+
%.o: %.cc $(global_deps)
@mkdir -p $(patsubst %/.,%,.deps/$(@D))
+ifeq ($(HAVE_CPPCHECK),1)
+ $(call quiet,CPPCHECK) --template="{file}:{line}: {severity}: {message}" --quiet --error-exitcode=1 $<
+endif
$(call quiet,CXX $(CPPFLAGS) $(CXXFLAGS)) -c $(FINAL_CXXFLAGS) $< -o $@ -MD -MP -MF .deps/$*.d
%.o: %.c $(global_deps)
@mkdir -p $(patsubst %/.,%,.deps/$(@D))
+ifeq ($(HAVE_CPPCHECK),1)
+ $(call quiet,CPPCHECK) --template="{file}:{line}: {severity}: {message}" --quiet --error-exitcode=1 $<
+endif
$(call quiet,CC $(CPPFLAGS) $(CFLAGS)) -c $(FINAL_CFLAGS) $< -o $@ -MD -MP -MF .deps/$*.d
.PHONY : clean
> ---
> Makefile.local | 10 ++++++++++
> configure | 11 +++++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/Makefile.local b/Makefile.local
> index af12ca7f..6a5168f1 100644
> --- a/Makefile.local
> +++ b/Makefile.local
> @@ -283,6 +283,16 @@ CLEAN := $(CLEAN) version.stamp notmuch-*.tar.gz.tmp
>
> DISTCLEAN := $(DISTCLEAN) .first-build-message Makefile.config sh.config
>
> +CLEAN := $(CLEAN) cppcheck.stamp
> +cppcheck: cppcheck.stamp
> +cppcheck.stamp: $(SRCS)
> +ifeq ($(HAVE_CPPCHECK),1)
> + cppcheck --template="{file}:{line}: {severity}: {message}" --quiet --error-exitcode=1 ${SRCS}
> + touch $@
> +else
> + @echo No cppcheck installed; skipping static checking
> +endif
> +
> DEPS := $(SRCS:%.c=.deps/%.d)
> DEPS := $(DEPS:%.cc=.deps/%.d)
> -include $(DEPS)
> diff --git a/configure b/configure
> index c5e2ffed..364854f3 100755
> --- a/configure
> +++ b/configure
> @@ -646,6 +646,14 @@ if [ $WITH_DESKTOP = "1" ]; then
> fi
> fi
>
> +printf "Checking for cppcheck... "
> +if command -v cppcheck > /dev/null; then
> + have_cppcheck=1
> + printf "Yes.\n"
> +else
> + printf "No.\n"
> +fi
> +
> libdir_in_ldconfig=0
>
> printf "Checking which platform we are on... "
> @@ -1065,6 +1073,9 @@ zsh_completion_dir = ${ZSHCOMLETIONDIR:=\$(prefix)/share/zsh/functions/Completio
> # build its own version)
> HAVE_CANONICALIZE_FILE_NAME = ${have_canonicalize_file_name}
>
> +# Whether the cppcheck static checker is available
> +HAVE_CPPCHECK = ${have_cppcheck}
> +
> # Whether the getline function is available (if not, then notmuch will
> # build its own version)
> HAVE_GETLINE = ${have_getline}
> --
> 2.14.1
next prev parent reply other threads:[~2017-08-27 8:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 14:41 make notmuch cppcheck clean David Bremner
2017-08-26 14:41 ` [PATCH 1/5] build: add target to run cppcheck David Bremner
2017-08-27 8:20 ` Jani Nikula [this message]
2017-08-29 11:35 ` [Patch v2] " David Bremner
2017-08-29 18:36 ` Jani Nikula
2017-08-29 18:47 ` Jani Nikula
2017-08-30 23:28 ` David Bremner
2017-08-26 14:41 ` [PATCH 2/5] cppcheck: close files during shutdown David Bremner
2017-08-26 14:41 ` [PATCH 3/5] cppcheck: call va_end in _internal_error David Bremner
2017-08-26 14:41 ` [PATCH 4/5] test/smtp-dummy: uncrustify David Bremner
2017-08-26 14:41 ` [PATCH 5/5] test/smtp-dummy: convert to 'goto DONE' style David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pobhl8wc.fsf@nikula.org \
--to=jani@nikula.org \
--cc=david@tethera.net \
--cc=notmuch@freelists.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).