From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 3ED756DE582B for ; Thu, 15 Mar 2018 08:22:45 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NQEmEe-J0sMR for ; Thu, 15 Mar 2018 08:22:44 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 659AF6DE4344 for ; Thu, 15 Mar 2018 08:22:44 -0700 (PDT) Received: from fifthhorseman.net (unknown [81.128.173.187]) by che.mayfirst.org (Postfix) with ESMTPSA id 7C9A2F99A; Thu, 15 Mar 2018 11:22:40 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 002BF20BC3; Thu, 15 Mar 2018 14:54:32 +0100 (CET) From: Daniel Kahn Gillmor To: David Bremner , Tomi Ollila , sh!zeeg , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] cli: looking for config file in $XDG_CONFIG_HOME In-Reply-To: <87d106qf29.fsf@tethera.net> References: <20180314124321.13848-1-shizeeque@gmail.com> <87d106qf29.fsf@tethera.net> Date: Thu, 15 Mar 2018 13:54:29 +0000 Message-ID: <87po451m22.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 15:22:45 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed 2018-03-14 22:54:06 -0300, David Bremner wrote: > There doesn't seem to be a good reason to drop ~/.notmuch-config > completely here. As Tomi notes, that would break notmuch for all current > users. I suppose I could live with $XDG_CONFIG_HOME/notmuch/config (or > whatever) taking precedence if it exists. If we ant to keep the config file, then i agree that $XDG_CONFIG_HOME/notmuch/config is probably the a better place for it than ~/.notmuch-config. But: It seemed to me that there was a growing consensus that the configfile could be phased out in favor of storing configuration details in the database itself. (this is dependent on someone=E2=84=A2 actually doing the implementation work, of course) if we do this, it seems likely that we'll need to keep around handling the config file for backward compatibility, via something like: * when we observe a config file, we could walk each option present in it. For each option: a) if that option is not present in the database, copy it into the database. b) if that option is present in the database, and it matches the option in the config file, ignore c) if that option is present in the database but does not match the config file, use the version in the config file but warn the user that they have a conflict they should probably resolve soon. after some number of versions has elapsed and we are ready to explicitly deprecate the config file, perhaps we convert situations (a) and (b) into warning messages and situation (c) into a hard error. This is all a bit confusing, but it is the price we pay for having a smooth transition that allows users to upgrade knowing they can roll back if a new version isn't working for them. So i think it would be a shame to have an additional layer of confusion added by having two different deprecated configuration files. So i lean against adopting this change. I'd much rather see work on phasing out the configfile. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTTaP514aqS9uSbmdJsHx7ezFD6UwUCWqp7FQAKCRBsHx7ezFD6 U8JOAQCUaT2Oq7QpPKu5LyS13u9B82ZjV5V5qU4R3Lkqv0GWywEAvhbf/+nFWE5g kiQq1vpw73h44o9F5Hwe/kpJihcOgAE= =+TDB -----END PGP SIGNATURE----- --=-=-=--