From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D1E3E6DE0207 for ; Wed, 10 Oct 2018 09:34:29 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.251 X-Spam-Level: X-Spam-Status: No, score=-0.251 tagged_above=-999 required=5 tests=[AWL=-0.051, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jKbGcFKZQb8R for ; Wed, 10 Oct 2018 09:34:28 -0700 (PDT) Received: from jb55.com (jb55.com [45.79.91.128]) by arlo.cworth.org (Postfix) with ESMTPS id 9FDAB6DE0192 for ; Wed, 10 Oct 2018 09:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d= jb55.com; h=from:to:subject:date:message-id; s=default; bh=1J80O4xeQtdx0jn60x9DqczTxmke4cv4OOU4NRT91kw=; b=ZSYYnr2qoLnzLtsJjNFU7XO2muhY7XaHZLZGTejsDkAO2Dlgw/727duoyGTZ4Kc9Zp+pYP2XTSTxTtGDy3Cn93xF8Y3ry1nswY2V+RaHpPLffhoOtd8bUzeV8kbAsKyLgqpeoSMqfxK5NiEYve29J5KsMfHSFaazdy7ajyRzHB99vieJvROx/HH+pX1B6Q7nposdxnA2akYLo6dlz69oLXSBYXjanQTW0z46YhZoaQuHzKyQOmdt6mz46Gaz7egYK3HwOXLQFlw/z1zgEFVfkoDJab9Z/eUEBCkc8WKebSiYTFCOT6WET/KpfOUJcviUSC/aDYlojzt/GZWR0uwoHQ== Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187]) by jb55.com (OpenSMTPD) with ESMTPSA id 75bbb056 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 10 Oct 2018 16:34:27 +0000 (UTC) From: William Casarin To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH RFC] index: add body: search query term In-Reply-To: <87in2arsjk.fsf@tethera.net> References: <20181010055326.19030-1-jb55@jb55.com> <87in2arsjk.fsf@tethera.net> Date: Wed, 10 Oct 2018 09:34:26 -0700 Message-ID: <87pnwh2225.fsf@jb55.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 16:34:29 -0000 David Bremner writes: > William Casarin writes: > I think you'll find you broke non-prefixed queries. Does the test suite > still pass? If so, we need more tests. yeah they seem to pass. but you're right, something seems a bit off: ./notmuch count subject:github or body:github and tag:notmuch 3271 ./notmuch count github and tag:notmuch 665 > of terms I'd be intersted how much this bloats the index. Ideally with > the performance corpus so we can all reproduce the experiment. sounds good, I was wondering that as well. I wonder if it's all worth the effort though, since a workaround could be: notmuch search and not subject: If it's too annoying to have a body prefix, due to index bloat or performance issues, would doing something hacky such as translating 'body:' to ' and not subject:' make sense? Will -- https://jb55.com