From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 49CD16DE0F5C
 for <notmuch@notmuchmail.org>; Thu,  9 May 2019 18:42:17 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.036
X-Spam-Level: 
X-Spam-Status: No, score=-0.036 tagged_above=-999 required=5
 tests=[AWL=-0.035, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id HpKgxF1-00Bq for <notmuch@notmuchmail.org>;
 Thu,  9 May 2019 18:42:16 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 643786DE0F50
 for <notmuch@notmuchmail.org>; Thu,  9 May 2019 18:42:16 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1hOuYB-00015w-2S; Thu, 09 May 2019 21:42:15 -0400
Received: (nullmailer pid 26106 invoked by uid 1000);
 Fri, 10 May 2019 01:42:13 -0000
From: David Bremner <david@tethera.net>
To: Will Dietz <w@wdtz.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib/message-file: close stream in destructor
In-Reply-To: <20190509200547.GG24880@dtznix>
References: <20190510002324.31140-1-david@tethera.net>
 <20190509200547.GG24880@dtznix>
Date: Thu, 09 May 2019 22:42:13 -0300
Message-ID: <87pnorhyq2.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2019 01:42:17 -0000

Will Dietz <w@wdtz.org> writes:

> Great, thank you!
>
> Much appreciated, I actually was running into this yesterday.
>
> ( which for whatever reason led to posting this on the subject:
> https://github.com/afewmail/afew/issues/193#issuecomment-490766850 )
>
> Would the valgrind support in the test suite catch this sort of thing
> (fd leak on relatively common path)?
>

Good question. It didn't in a naive test I tried (just running notmuch
new under valgrind --track-fds). This is probably has to do with glib
cleaning up the relevant objects during shutdown.