From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: v3 of test speedup by replacing gdb with LD_PRELOAD
Date: Sat, 29 Jun 2019 21:14:35 +0200 [thread overview]
Message-ID: <87pnmwdx0k.fsf@tethera.net> (raw)
In-Reply-To: <m2ftnwf9p4.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Wed, Jun 26 2019, Daniel Kahn Gillmor wrote:
>
>> Here are the two patches from this series, revised according to the
>> on-list discussion.
>>
>> In particular, the revision from Bremner's original series are:
>>
>> * LD_PRELOAD is now prepended to, not clobbered (thanks, Tomi!)
>> * gen_insert_msg is not moved
>>
>> We still don't deal with platforms that don't support LD_PRELOAD (like
>> MacOS), but i'd encourage us to take Ralph at his word and go ahead
>> with these changes now, cleaning them up on those platforms later.
>
> Agreed. Series LGTM.
>
>>
>> --dkg
Pushed to master. Thanks to both of you for polishing that up.
d
prev parent reply other threads:[~2019-06-29 19:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 13:08 start to replace dependence of test suite on gdb with LD_PRELOAD shims David Bremner
2019-05-26 13:08 ` [PATCH 1/2] test: provide machinery to make and use test_shims David Bremner
2019-06-25 21:05 ` Tomi Ollila
2019-06-25 23:33 ` Daniel Kahn Gillmor
2019-05-26 13:08 ` [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh David Bremner
2019-06-09 22:47 ` Daniel Kahn Gillmor
2019-06-10 21:34 ` Ralph Seichter
2019-06-14 11:16 ` David Bremner
2019-06-24 18:22 ` Daniel Kahn Gillmor
2019-06-24 18:44 ` Tomi Ollila
2019-06-24 20:12 ` Daniel Kahn Gillmor
2019-06-24 19:56 ` Ralph Seichter
2019-06-10 0:52 ` Daniel Kahn Gillmor
2019-06-10 0:53 ` [PATCH v2 " Daniel Kahn Gillmor
2019-06-16 11:35 ` Tomi Ollila
2019-06-16 16:38 ` Daniel Kahn Gillmor
2019-06-26 16:23 ` v3 of test speedup by replacing gdb with LD_PRELOAD Daniel Kahn Gillmor
2019-06-26 16:23 ` [PATCH v3 1/2] test: provide machinery to make and use test_shims Daniel Kahn Gillmor
2019-06-26 16:23 ` [PATCH v3 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh Daniel Kahn Gillmor
2019-06-26 19:06 ` v3 of test speedup by replacing gdb with LD_PRELOAD Tomi Ollila
2019-06-29 19:14 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnmwdx0k.fsf@tethera.net \
--to=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).