From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: simplify handling of writable database modes
Date: Tue, 28 Jul 2020 08:52:27 -0300 [thread overview]
Message-ID: <87pn8frh50.fsf@tethera.net> (raw)
In-Reply-To: <m2ft9csxnf.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Sun, Jul 26 2020, David Bremner wrote:
>
>> As the last commit message mentions, it is a bit hard to be sure one
>> is using static_cast correctly, so this series eliminates
>> the use of static_cast for Xapian database objects.
>>
>> As a bonus, it deletes more code than it adds.
>>
>> Based on a suggestion from Olly Betts.
>
>
> Series LGTM.
>
> Tomi
applied to master
prev parent reply other threads:[~2020-07-28 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 23:31 simplify handling of writable database modes David Bremner
2020-07-26 23:31 ` [PATCH 1/3] lib: drop two gratuitous assignments to database mode David Bremner
2020-07-26 23:31 ` [PATCH 2/3] lib: encapsulate the use of notmuch_database_t field 'mode' David Bremner
2020-07-26 23:31 ` [PATCH 3/3] lib: replace use of static_cast for writable databases David Bremner
2020-07-27 16:58 ` simplify handling of writable database modes Tomi Ollila
2020-07-28 11:52 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn8frh50.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).