From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MDd0H2SAjmA2sQAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 12:35:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MK0lG2SAjmBwWAAAB5/wlQ (envelope-from ) for ; Sun, 02 May 2021 10:35:16 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB9FF2BFD6 for ; Sun, 2 May 2021 12:35:15 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2F2B427179; Sun, 2 May 2021 06:35:12 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id A49F21FBC9 for ; Sun, 2 May 2021 06:35:09 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 99A0C60016; Sun, 2 May 2021 06:35:09 -0400 (EDT) Received: (nullmailer pid 870171 invoked by uid 1000); Sun, 02 May 2021 10:35:08 -0000 From: David Bremner To: Tobias Backer Dirks , notmuch@notmuchmail.org Subject: Re: [PATCH] cli: handle bash completion of all shared options In-Reply-To: <20210426181220.1097563-1-omgitsaheadcrab@gmail.com> References: <20210426181220.1097563-1-omgitsaheadcrab@gmail.com> Date: Sun, 02 May 2021 07:35:08 -0300 Message-ID: <87pmy9o23n.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: MTB4GSWHQ5CL6HQ7F32WN3PVNDTSKSTP X-Message-ID-Hash: MTB4GSWHQ5CL6HQ7F32WN3PVNDTSKSTP X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619951715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FJ0/yOnJ0z3sUhh9Uq+MCGpWB5416u32rihYH5iPWmU=; b=mMJUwzV7Cn1lRNG+PfBaH3DEApYJHPl/Cq2qn8nE/XsvMW8FXjLRBsTA9kmeOD/5r1pvJ2 G8e9fIZqIOvw8OXQspFozSBozG7cAf3IXthbl/nDB6+mLmgvMqrQjuSj8xm/pHt+VM1qOY m2CsLYOSy830Bf2co42Hw3sKJ36BSqml1LDj9oiqhhn+l+1yfp0K0mQUQQjo2UWvpiYCr2 4rVokHnSjgFpJ144u23eO6qSdm2vpR/w+oSx/LAuDJo+1VdM7R+VzvwZLDZQII+rAcJaWF Tt+vZeK1z6ILpYANbJSRh+PLPwTQAOlJk7a0PeHQmPOvdYtN+5W+wLAL9z+FGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619951715; a=rsa-sha256; cv=none; b=GwwTiNeYwzZWBJwmsWpcMY+DSEcyCRG89QbQ64TlcDOMuJRjpqGHoQpUGQKl2+y9TGLAYB t24k245l0/792manFT9nv/ZVV3uIAINznfiBn3DCcPFCG4Cq9mEaogTMAaTSWh6SOK3Jhz pbVx7+Cm8P3hbVd0MWUE9PXx4nTORQRi0wDkNfLxDs4upeiU+Xq2kMWFsexZyjzpPrSvdA Z1bJ7iI+B+cRs2elQP+CpJUL2GUE/7xByAQYmQNJBQAeF0Uqmkagi4od8ApM4hX06yg7C2 E11HU2KEPxGdLYfgHbrsurYzHShHOz43CHK1RlUxJjxzGIHaXl4PrDnf1fE+ag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: AB9FF2BFD6 X-Spam-Score: -2.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9wsZsB1el+ik Tobias Backer Dirks writes: > A slight rework of base bash completion to handle all shared options. > This simplifies the handling of base commands and adds creature comforts > such as directory completion for --config, and removing trailing spaces > from options ending in an `=`. Also fixes a bug reported in [1], wherein > completion after an `=` produced erroneous output. > > [1]: id:20200602103703.GA13623@taurus.defre.kleine-koenig.org > > Signed-off-by: Tobias Backer Dirks Thanks for the patch. Zsh user here, so I'm hoping it will be reviewed by someone who uses bash as their daily driver. d