unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tobias Backer Dirks <omgitsaheadcrab@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: handle bash completion of all shared options
Date: Sun, 02 May 2021 07:35:08 -0300	[thread overview]
Message-ID: <87pmy9o23n.fsf@tethera.net> (raw)
In-Reply-To: <20210426181220.1097563-1-omgitsaheadcrab@gmail.com>

Tobias Backer Dirks <omgitsaheadcrab@gmail.com> writes:

> A slight rework of base bash completion to handle all shared options.
> This simplifies the handling of base commands and adds creature comforts
> such as directory completion for --config, and removing trailing spaces
> from options ending in an `=`. Also fixes a bug reported in [1], wherein
> completion after an `=` produced erroneous output.
>
> [1]: id:20200602103703.GA13623@taurus.defre.kleine-koenig.org
>
> Signed-off-by: Tobias Backer Dirks <omgitsaheadcrab@gmail.com>

Thanks for the patch. Zsh user here, so I'm hoping it will be reviewed
by someone who uses bash as their daily driver.

d

  reply	other threads:[~2021-05-02 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 18:12 [PATCH] cli: handle bash completion of all shared options Tobias Backer Dirks
2021-05-02 10:35 ` David Bremner [this message]
2021-12-04 15:50 ` David Bremner
2021-12-25 16:58 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmy9o23n.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=omgitsaheadcrab@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).