From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CF6YED8HQ2LmSQEAgWs5BA (envelope-from ) for ; Tue, 29 Mar 2022 15:18:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oHAEDj8HQ2LUhAEA9RJhRA (envelope-from ) for ; Tue, 29 Mar 2022 15:18:55 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B162DAD22 for ; Tue, 29 Mar 2022 15:18:54 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E53085F6D3; Tue, 29 Mar 2022 13:18:51 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id E582F5F5E5 for ; Tue, 29 Mar 2022 13:18:48 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1000) id D63CC5FBD7; Tue, 29 Mar 2022 09:18:47 -0400 (EDT) From: David Bremner To: Alexander Adolf , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show In-Reply-To: <9cc1c3dc135b5126efd210ee97b88d6b@condition-alpha.com> References: <9cc1c3dc135b5126efd210ee97b88d6b@condition-alpha.com> Date: Tue, 29 Mar 2022 09:18:47 -0400 Message-ID: <87pmm43nig.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: WREBT4YEHEKCHIPU7IRB5WSCTJ3GSSZT X-Message-ID-Hash: WREBT4YEHEKCHIPU7IRB5WSCTJ3GSSZT X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648559935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=sLJNAy1CNLAoeXCQvzrvPIudadaLbyaTZFnqxGYeCD0=; b=Fa5qPJuVRM17hXuZoOojopMsMt72Gr+ok1dzq67vV2yKpYCbHPYCnxUURcuC7K0tHiO9Yt CtFOJI41WSZccU3DhONgWAOITlesUWj04nTN5RDgK/fdGJEsWbQlXWBAw7U/0DsipNxWsX 0bRo4I+pl5To7xJCnvBaahg3e7Cu1Lz19n+/zuPtQLDJyNxCK/85PhO//C8BAu8uhk1drO EyChBgn+jgYBrbWxornOqAcuzR7IcUxARy3quwT8G84IDKUksGU72D8SChnXSFVAJ7MrWl NwBq3NiJfGWxX7F1nd9flC8HvBVLn6FuIUUpaKtZIsBLrRXFhK3Bl/OGLHp71A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648559935; a=rsa-sha256; cv=none; b=YtGXXw+H3bv9Wmaj74M/TQQf6xqMRmWl/K3RfVx0Y6R03HxuK6CbbMO+NsMJZG73/ByXs/ QM82uKjGiQMcyp5KIc7kkSvYW+il/5yYcjy1iuN19CjQseP9mZNmmONy15mipqtJqwT/z7 4576vd6SyjAgtHXgZ0K8itZt5MKjQ75tAanFGJkBNpNUVSa98+bImcds8TL3FIWrX1wIsN +IyM70WTsehmK8OLsxJREGbN+tP2SS0mfEQlVtFL60BkqHnvXtAUf1JQm4T/5U/8IZsUeR T05InhDjlKOzcX5mqmM1d5yXwBA9lVBOe1SgCHkbT0PlT80Je6mRxRLV4ikq6Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.03 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B162DAD22 X-Spam-Score: -1.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: Cn8NwC2j0QeH Alexander Adolf writes: > The issue I saw with S/MIME encrypted messages was, that the processing > of the MIME tree stopped after decryption. It turned out there was no > handler for application/(x-)?pkcs-mime type entities in notmuch-show.el, > and the "handler of last resort" notmuch-show-insert-part-*/* was > called. Thus, this patch just adds a notmuch-show handler for > application/(x-)?pkcs-mime type entities. Hi Alexander; Thanks for sending that. It's a bit tricky to review SMIME stuff as I believe none of the devs is really using SMIME regularly. One thing that would help is adding one or more tests. Basically the test suite already has a SMIME certificate, so if you can encrypt a message to that cert (or use one of the existing ones), you can test that the message displays OK in Emacs. The corresponding test set would probably be T450-emacs-show, but it might be easier to add to T355-smime. Eventually we'll also need a short update to doc/notmuch-emacs.rst. I hope that helps move review forward, David