From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WMbqMjBYHmPUZgEAbAwnHQ (envelope-from ) for ; Sun, 11 Sep 2022 23:50:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4Pz5MjBYHmME2wAA9RJhRA (envelope-from ) for ; Sun, 11 Sep 2022 23:50:40 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24D333B914 for ; Sun, 11 Sep 2022 23:50:40 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 8D9F55E027; Sun, 11 Sep 2022 21:50:37 +0000 (UTC) Received: from harrington.uberspace.de (harrington.uberspace.de [185.26.156.85]) by mail.notmuchmail.org (Postfix) with ESMTPS id 0DCB15E016 for ; Sun, 11 Sep 2022 21:50:35 +0000 (UTC) Received: (qmail 21665 invoked by uid 500); 11 Sep 2022 21:50:34 -0000 From: Justus Winter To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: compute expected keyid from fingerprint In-Reply-To: References: <20220909161250.715226-1-justus@sequoia-pgp.org> Date: Sun, 11 Sep 2022 23:50:18 +0200 Message-ID: <87pmg14m3p.fsf@europ.lan> MIME-Version: 1.0 X-Rspamd-Bar: ----- X-Rspamd-Report: MIME_GOOD(-0.2) SIGNED_PGP(-2) BAYES_HAM(-2.996615) X-Rspamd-Score: -5.196615 Received: from unknown (HELO unkown) (::1) by harrington.uberspace.de (Haraka/2.8.28) with ESMTPSA; Sun, 11 Sep 2022 23:50:34 +0200 Message-ID-Hash: AILTIW5FOH6AIGMAPEOJFQRXYIRRI66O X-Message-ID-Hash: AILTIW5FOH6AIGMAPEOJFQRXYIRRI66O X-MailFrom: justus@sequoia-pgp.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============0403741511044706867==" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662933040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=52jK/laGFAb96xNKMvLFFnjDEZMNR2batRQBbeJ1iAc=; b=jmU7Wp7rqsGDBDt/wUUOc41fEeFy90hkX+xqay2tTPS+q6Uq1je7/rVirM8VQb7cbM72R8 kLhYKnaeaT9brp5pcayS8V1RnfP8bu13lxwuosRBAtwLW0HaohuiF3ehhBfER1Niaa10vK D3XIei2irevxASvVmYR2c6U0XTwBAP5nrTiOCptApmV6tD+yPzQewYJRbPhzxgyXx8oCPq gx7/ahNYBBRVTfPEqxm436zFM5VHHNoXViBWKewqhWWFqlJj4swVHiUUJWP94IEFFl8TKb rOJITkm1QFK+Pi9KUfjEYaA/iduGZSlKsluwchFbqG0l7HGJg1V79M0jgydcBQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662933040; a=rsa-sha256; cv=none; b=PDqmRb0WKH3wANPFzhg9g9pr7gh8i/TRWbYag+IxYmz0oQc5Ua4KxRpV1vFdB0PqUvxWN5 UkaU7YIX8bNX3vMkPqKIH/76+KdGW4+cyTdfx22XQwE4Ba/Mfrm+h4lJodkFwgYO7oLyoK 36KVqNy+tr2uKdE5kphTpONE7S4G1+BqZCTyI9HzHOPqcSwTD4RcXjPfMEUxFrMsSoF7c0 owNu30TrIruW0K7yU7Q0UOaZMjRXPbiVBNnovx5o9UNDw5VEewPcxI8tp0XD38hMrlhgxY 8MO+hXb2fCZNw8fi7lBml+EymMv/erwtrUB2ECYvQGaoGEpcQwU1kr4mP571iA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -4.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 24D333B914 X-Spam-Score: -4.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: uwnAA81b/tTQ --===============0403741511044706867== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Tomi Ollila writes: > On Fri, Sep 09 2022, Justus Winter wrote: > >> --- >> test/T350-crypto.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh >> index 3c6626b4..721cbfdd 100755 >> --- a/test/T350-crypto.sh >> +++ b/test/T350-crypto.sh >> @@ -467,7 +467,7 @@ expected='[[[{"id": "XXXXX", >> "Date": "Sat, 01 Jan 2000 12:00:00 +0000"}, >> "body": [{"id": 1, >> "sigstatus": [{"status": "error", >> - "keyid": "6D92612D94E46381", >> + "keyid": "'$(echo $FINGERPRINT | cut -c 25-)'", > > The "bashism" (works also in zsh) ${FINGERPRINT:24} works here > (and has been used in other lines in this file Interesting. FTR, I saw this method being used elsewhere and simply copied it. If that'd prevent merging the change, I'd actually prefer introducing a variable KEYID that is set explicitly in the test library. The reason for that is that in v5 OpenPGP, the keyid will be computed differently. Justus --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFLBAEBCgA1FiEEJWpOVeSnLZetJGjniNx+MzhfeR0FAmMeWBoXHGp1c3R1c0Bz ZXF1b2lhLXBncC5vcmcACgkQiNx+MzhfeR1JWggAtcvSGtjbCNa9VzqnBkst3rSB 4ATyFA389vTq38r4BEKi9g3Mv0yC2P3ray1FLfIz8PufKsf9BzxNbfNBaSHP5cb/ es7x2aMNr2p/l0b2CDNy3vGyMCHxhvfegdf8E7hAhX9j5a8DH5blAt0Jcd+XrvVB no4mwOVlpUmuQe1+mgYgYwsNDqKmKAkwJAkRRYti0BA65+10mi+BGyFUY7uhhn0m ZZ45c6+60KWv+sOV5yJcyfUMJ5D1gULtg73+VW7xGn7BF78/ewB+AGb1xvKpGGlH ryED9ePHQ+FqUv81U8A3+5ln9wIwWYv4Wp/Y7CrNYtPFhOASjLNUGK+RQ5uohA== =kuF6 -----END PGP SIGNATURE----- --=-=-=-- --===============0403741511044706867== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============0403741511044706867==--