From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MGdOJFINAGRO3QAAbAwnHQ (envelope-from ) for ; Thu, 02 Mar 2023 03:43:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2I1DJFINAGRiYwEAauVa8A (envelope-from ) for ; Thu, 02 Mar 2023 03:43:30 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8AB53B0E1 for ; Thu, 2 Mar 2023 03:43:29 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id ECEC55F42B; Thu, 2 Mar 2023 02:43:26 +0000 (UTC) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1FC6E5F3E2 for ; Thu, 2 Mar 2023 02:43:24 +0000 (UTC) Received: from graphene.canonical.com (1.general.amurray.us.vpn [10.172.65.220]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 161F341E0E; Thu, 2 Mar 2023 02:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1677725003; bh=gtx4cvPAwDTCAyV8tEDT/cFvxKJgi5tPPum82MdQiY4=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HkdMAU17RzE94G/d3Iq8orfGpwKIkYk1904d/ruEXYFHkcdekngMztdsGkQmsNkwo oVkx2QgVAEjeGUUSVr4w6mWdAL3K3R1uhfuzIeUUEGHy/W2LKOxHb5f1NdT3PfJfyX DGjbu5DlhzqJwFOZAd3yKlwuFcyscIRvakS1LBNFTfYP4ZEDKb5qzi/Y9L3ms1bDob y+i4peEe6bPEyP9Xb158dnMeHnqVJujXp7pCwfsSwLgGiY8hqEQ7oVZwiR2T9+KWKy yBNVVy2Qe6lDKPAw5feykY6wboqF5LOsgi5ZXZHmkJz/BTSelhIOFhT6kInK9TGvXe 1bGktPZ22l5KA== From: Alex Murray To: David Bremner , notmuch@notmuchmail.org Subject: Re: notmuch-emacs inline image display broken in emacs-29 In-Reply-To: <87ilfpvotj.fsf@tethera.net> References: <87ilfrg035.fsf@graphene.mail-host-address-is-not-set> <87bklhricc.fsf@tethera.net> <87ilfpvotj.fsf@tethera.net> Date: Thu, 02 Mar 2023 13:13:18 +1030 Message-ID: <87pm9r6fg9.fsf@graphene.mail-host-address-is-not-set> MIME-Version: 1.0 Message-ID-Hash: RMBGNGW4D4VPUEEBRYQV3ZIE5L6XOOIF X-Message-ID-Hash: RMBGNGW4D4VPUEEBRYQV3ZIE5L6XOOIF X-MailFrom: alex.murray@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677725010; a=rsa-sha256; cv=none; b=acgXrA68XqyadwMzYVuvGLoBc6dCUKELjlucJT7rUvnKKrVtiIdyUvZL9EUBxpkzW+Ypja IC4QyS+4ToqSl0DIHAtZ5YNHlr9ny9lbjCljgaIzLClXoc//Ic2H0NJLvNf25DkoQQawRf eSws7dUY83cR+AW2nG75eARbJXdjPjWqWLyB+tL3k9Hzlgqetubm32LxA/M3CFkMOs/SQz xO2mJSHcjeBITH/cYmOV88BFbsdjDHVtlqqmoOdlH4EpdBj4zkqKfUd1GaWmZgs7OHF4Wz z4JPDIE1gchAhkAneBh3Zf9KgtH+X/uc915KEgV5+8Ardx1F1dMFy7ktyixLnw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=canonical.com header.s=20210705 header.b=HkdMAU17; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=canonical.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677725010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=l6CQZZOlHh3n25AZLf7/2WE2+R1PIjc94csxo+hrVJY=; b=FKbYQNG3Gd/RKW7NP4yjDpuCQ7uWE7UYuQ6s5iURdGMCFRstdqeLrodoCXr3c1ph6xA4zY abrXjgq/2J5hn3jvBxgTYdDWR9j2gUD7wZY2LpQ9pnoHaiU6nZ8+pePcOLUVp78CAdhJoP kxgAB3fYAmk72MYYwpKUm4ucx+G2V2Vxgx5dO8h8TFB0FZpSDFqzgbKrHQLUpSKqcvSOYM qnxtzVq4+3A3kKsqONJzqYZS+Bgpct4AyOD3UUcVWBD6PfxNgqnsRmkxyzPFWYb58YEmAV XrKaBfgz2btzJJDze/597XDPlZkCHvjoLBvSdyUJhFB7eykMd3ZDW1ZChSEkQQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.70 X-Spam-Score: -0.70 X-Migadu-Queue-Id: A8AB53B0E1 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=canonical.com header.s=20210705 header.b=HkdMAU17; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=canonical.com (policy=none) X-TUID: RvP91ID0Ix3M On Sat, 2023-02-25 at 09:48:08 -0400, David Bremner wrote: > David Bremner writes: > >> Alex Murray writes: >> >> I tried replacing indent-rigidly with a simplified version the and that >> leaves the image inserted, but unfortunately doesn't indent it >> properly. If you want to play with it, my half working patch is >> attached. >> > > Actually, the current implementation using indent-rigidly doesn't indent > inlined images properly either, so maybe that is a way forward. I > remember from last time I considered globally replacing our use of > indent-rigidly [1] there were a few issues to be dealt with, but maybe > this is a reasonable approach. > Thanks for the patch David - I tried the one attached to the previous email it but it doesn't seem to fix the issue for me. I also tried the one in [1] and that did seem to help - images in replies (and hence emails that by default are displayed with an indent) show up now, but not for emails that are the first ones in a thread (and hence have no indent by default). (although I notice in a recent conversation in #notmuch that it did appear to work for one user - but not sure which patch they were using). Any ideas where I should start trying to debug this on my side? I am using a pretty recent build of emacs from master with a the latest notmuch-emacs bits from MELPA - https://melpa.org/#/notmuch (and the notmuch binary 0.37 - as packaged in Ubuntu 23.04 with version 0.37-1ubuntu3 FWIW). > [1]: https://nmbug.notmuchmail.org/nmweb/show/20211214121726.2631714-1-david@tethera.net > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org