unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Alex Murray <alex.murray@canonical.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: notmuch-emacs inline image display broken in emacs-29
Date: Thu, 02 Mar 2023 13:13:18 +1030	[thread overview]
Message-ID: <87pm9r6fg9.fsf@graphene.mail-host-address-is-not-set> (raw)
In-Reply-To: <87ilfpvotj.fsf@tethera.net>

On Sat, 2023-02-25 at 09:48:08 -0400, David Bremner wrote:

> David Bremner <david@tethera.net> writes:
>
>> Alex Murray <alex.murray@canonical.com> writes:
>>
>> I tried replacing indent-rigidly with a simplified version the and that
>> leaves the image inserted, but unfortunately doesn't indent it
>> properly. If you want to play with it, my half working patch is
>> attached.
>>
>
> Actually, the current implementation using indent-rigidly doesn't indent
> inlined images properly either, so maybe that is a way forward. I
> remember from last time I considered globally replacing our use of
> indent-rigidly [1] there were a few issues to be dealt with, but maybe
> this is a reasonable approach.
>

Thanks for the patch David - I tried the one attached to the previous
email it but it doesn't seem to fix the issue for me.

I also tried the one in [1] and that did seem to help - images in
replies (and hence emails that by default are displayed with an indent)
show up now, but not for emails that are the first ones in a thread (and
hence have no indent by default).

(although I notice in a recent conversation in #notmuch that it did
appear to work for one user - but not sure which patch they were using).

Any ideas where I should start trying to debug this on my side?

I am using a pretty recent build of emacs from master with a the latest
notmuch-emacs bits from MELPA - https://melpa.org/#/notmuch (and the
notmuch binary 0.37 - as packaged in Ubuntu 23.04 with version
0.37-1ubuntu3 FWIW).

> [1]: https://nmbug.notmuchmail.org/nmweb/show/20211214121726.2631714-1-david@tethera.net
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

  reply	other threads:[~2023-03-02  2:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24  4:26 notmuch-emacs inline image display broken in emacs-29 Alex Murray
2023-02-25 13:21 ` David Bremner
2023-02-25 13:48   ` David Bremner
2023-03-02  2:43     ` Alex Murray [this message]
2023-04-04 21:44       ` Al Haji-Ali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm9r6fg9.fsf@graphene.mail-host-address-is-not-set \
    --to=alex.murray@canonical.com \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).