From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EBI7FokCWGTQbgAASxT56A (envelope-from ) for ; Sun, 07 May 2023 21:56:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qBZEFokCWGQ7/AAAauVa8A (envelope-from ) for ; Sun, 07 May 2023 21:56:57 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D86341E7AD for ; Sun, 7 May 2023 21:56:56 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1ECB85F36A; Sun, 7 May 2023 19:56:55 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [192.99.9.157]) by mail.notmuchmail.org (Postfix) with ESMTPS id 22EEA5F342 for ; Sun, 7 May 2023 19:56:53 +0000 (UTC) Received: from tethera.net (unknown [75.104.166.118]) by phubs.tethera.net (Postfix) with ESMTPS id C70F418005B; Sun, 7 May 2023 16:56:46 -0300 (ADT) Received: (nullmailer pid 235554 invoked by uid 1000); Sun, 07 May 2023 13:19:44 -0000 From: David Bremner To: mohkale@kisara.moe, notmuch@notmuchmail.org Subject: Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded In-Reply-To: <20230416131811.658253-2-mohkale@kisara.moe> References: <87v8re66mg.fsf@tethera.net> <20230416131811.658253-1-mohkale@kisara.moe> <20230416131811.658253-2-mohkale@kisara.moe> Date: Sun, 07 May 2023 07:19:44 -0600 Message-ID: <87pm7cp9cf.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: CCJ3PBOBLIUN7L63BMQEXV4QWLHYGDZN X-Message-ID-Hash: CCJ3PBOBLIUN7L63BMQEXV4QWLHYGDZN X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Mohsin Kaleem X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683489416; a=rsa-sha256; cv=none; b=L9SpAI7XC8a8HSI2BSqhO4oTUYR/TA50qN05jvXPTL+H5H4ehKMQ8V1/TRN/f398ySRQab Skx0iveShPQGu/g6bkSWPeMu2KQT78NFVSC+nkrc8oS7kYZ7bHOEMQor+yl03PyXc9ghTE b1hAJOvNX+4ogSCsCAApUxt/0oJToPemr9TdMCoSrUBeWIo9b7t0hyKSxgi+XuiOpKgWqE +wq5ql/GfLFA+CjHSR/cdt3OhV2Wb7oZFT+48ZDVNJzsXtLDkTjwGXx95cr4UWSknLMHrH VCk79TkxZh7xkk2o5UKIIXFNY5Me8kAuWxowbQdyisFGqjC5UqVfB344lZ6E9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683489416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=59lh9gdTvlc7BtipuPtZWm25OYzx/YQFfW4VeLOURZg=; b=FZYB+bv2MqNuLIaVhbMxxhfZErxcevqVQLQkDnQU4p1iXAfJAjyBgQBT9ZmERUiFirkn+M NSYszNfLnsx+mxXkDPx+rqu4eU2xxxnMqDQaMgxzUJevHO9qA8KI5Be9aEaLoxTNeQFZDG mNn3tcxT3ANF0i8Wxc4+kQl7F/EcaDAVyqNbM06aaal0TiVBrAiluvqyi2ybF3p23oRYSX +35QFoLC7gqEbax7mzH2omvgfJrCvl1Azsr0tjDpAnkmWR7uAk+uPL7o8I/KC3O+qfCOFU Hjib2Wt8/AawOCzXsGMuONlJWJGOu458jI8w+YMwMM5EKswdIGqaxfdaYOax6w== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.39 X-Spam-Score: -1.39 X-Migadu-Queue-Id: D86341E7AD X-TUID: d+cun2ZIhZV1 mohkale@kisara.moe writes: > Lastly I've amended some calls to notmuch-tree and notmuch-unthreaded > which didn't pass through the buffer local value of > notmuch-search-oldest-first (and now notmuch-search-exclude). > Examples of where I've done this > + include notmuch-jump-search if respinning, move 'include' to previous line > > If there was a reasoning behind these not persisting the value of these > variables then we should revert it before merging and discuss whether > it's worth persisting notmuch-search-exclude. > I think the fixes are fine, and make sense to include since you are touching that code anyway. This sentence probably doesn't belong in the commit message, so if respinning the series, I would drop it.