From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cworth@cworth.org>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5BEAB431FC0;
	Fri, 27 Nov 2009 22:56:36 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id r7s2NMXTN+Dj; Fri, 27 Nov 2009 22:56:35 -0800 (PST)
Received: from cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 349F8431FAE;
	Fri, 27 Nov 2009 22:56:35 -0800 (PST)
From: Carl Worth <cworth@cworth.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <1259388425-32510-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
References: <1259311332-14557-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
	<1259388425-32510-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Date: Fri, 27 Nov 2009 22:56:20 -0800
Message-ID: <87ocmnqgrv.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH -v6] notmuch.el: Add face support to search mode
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Nov 2009 06:56:36 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Sat, 28 Nov 2009 11:37:05 +0530, "Aneesh Kumar K.V" <aneesh.kumar@linux.=
vnet.ibm.com> wrote:
> This patch use notmuch-tag-face showing tags in the
> notmuch-search-mode.

Thanks, Aneesh! Your patience has prevailed again and I've pushed out
this patch.

> We can selectively highlight each tag by setting notmuch-tag-face-alist a=
s below
>=20
> (defface notmuch-tag-unread-face
>  '((((class color)) (:foreground "goldenrod")))
>   "Notmuch search mode face used to highligh tags.")
>=20
> (defface notmuch-tag-inbox-face
>  '((((class color)) (:foreground "red")))
>   "Notmuch search mode face used to highligh tags.")
>=20
> (setq notmuch-tag-face-alist '(("unread" . 'notmuch-tag-unread-face)
> 			       ("inbox" . 'notmuch-tag-inbox-face)))

I'm a bit concerned that this documentation is going to just disappear
in the commit log and not be where people might actually look for
it. You've got the beginnings of the documentation here:

> +(defvar notmuch-tag-face-alist nil
> +  "List containing the tag list that need to be highlighed")

Which could be expanded to include basically the example above.

Anyway, thanks for the patch.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLEMmU6JDdNq8qSWgRAq7HAJ4hEEFuXb07bAjMQmUAviLPdaCzqwCffeu8
+Ud+wjeazF5XrqDK0HgR4zg=
=ZODZ
-----END PGP SIGNATURE-----
--=-=-=--