* [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.
@ 2010-02-15 9:41 David Edmondson
2010-02-15 10:03 ` David Edmondson
2010-04-07 19:28 ` Carl Worth
0 siblings, 2 replies; 5+ messages in thread
From: David Edmondson @ 2010-02-15 9:41 UTC (permalink / raw)
To: notmuch
---
notmuch.el | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/notmuch.el b/notmuch.el
index 8090b2f..3e8e50d 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -703,6 +703,7 @@ is what to put on the button."
(let* ((cite-start (match-beginning 0))
(cite-end (match-end 0))
(cite-lines (count-lines cite-start cite-end)))
+ (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face)
(when (> cite-lines (1+ notmuch-show-citation-lines-prefix))
(goto-char cite-start)
(forward-line notmuch-show-citation-lines-prefix)
@@ -718,6 +719,7 @@ is what to put on the button."
(let* ((sig-start (match-beginning 0))
(sig-end (match-end 0))
(sig-lines (1- (count-lines sig-start end))))
+ (overlay-put (make-overlay sig-start end) 'face 'message-cited-text-face)
(if (<= sig-lines notmuch-show-signature-lines-max)
(notmuch-show-region-to-button
sig-start
--
1.6.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.
2010-02-15 9:41 [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face David Edmondson
@ 2010-02-15 10:03 ` David Edmondson
2010-02-16 10:22 ` Michal Sojka
2010-04-07 19:28 ` Carl Worth
1 sibling, 1 reply; 5+ messages in thread
From: David Edmondson @ 2010-02-15 10:03 UTC (permalink / raw)
To: notmuch
This version is over-eager in marking (non-)signatures. The second call
to 'overlay-put' needs to move inside the 'if' a line below.
On Mon, 15 Feb 2010 09:41:49 +0000, David Edmondson <dme@dme.org> wrote:
> ---
> notmuch.el | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/notmuch.el b/notmuch.el
> index 8090b2f..3e8e50d 100644
> --- a/notmuch.el
> +++ b/notmuch.el
> @@ -703,6 +703,7 @@ is what to put on the button."
> (let* ((cite-start (match-beginning 0))
> (cite-end (match-end 0))
> (cite-lines (count-lines cite-start cite-end)))
> + (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face)
> (when (> cite-lines (1+ notmuch-show-citation-lines-prefix))
> (goto-char cite-start)
> (forward-line notmuch-show-citation-lines-prefix)
> @@ -718,6 +719,7 @@ is what to put on the button."
> (let* ((sig-start (match-beginning 0))
> (sig-end (match-end 0))
> (sig-lines (1- (count-lines sig-start end))))
> + (overlay-put (make-overlay sig-start end) 'face 'message-cited-text-face)
> (if (<= sig-lines notmuch-show-signature-lines-max)
> (notmuch-show-region-to-button
> sig-start
> --
> 1.6.6.1
>
dme.
--
David Edmondson, http://dme.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.
2010-02-15 10:03 ` David Edmondson
@ 2010-02-16 10:22 ` Michal Sojka
2010-02-16 10:53 ` David Edmondson
0 siblings, 1 reply; 5+ messages in thread
From: Michal Sojka @ 2010-02-16 10:22 UTC (permalink / raw)
To: David Edmondson, notmuch
Nice, it works for me.
On Mon, 15 Feb 2010 10:03:32 +0000, David Edmondson <dme@dme.org> wrote:
> This version is over-eager in marking (non-)signatures. The second call
> to 'overlay-put' needs to move inside the 'if' a line below.
Could you please send a fixed patch so that it can be applied easilly.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.
2010-02-16 10:22 ` Michal Sojka
@ 2010-02-16 10:53 ` David Edmondson
0 siblings, 0 replies; 5+ messages in thread
From: David Edmondson @ 2010-02-16 10:53 UTC (permalink / raw)
To: Michal Sojka, notmuch
On Tue, 16 Feb 2010 11:22:01 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> Nice, it works for me.
>
> On Mon, 15 Feb 2010 10:03:32 +0000, David Edmondson <dme@dme.org> wrote:
> > This version is over-eager in marking (non-)signatures. The second call
> > to 'overlay-put' needs to move inside the 'if' a line below.
>
> Could you please send a fixed patch so that it can be applied easilly.
Sebastian posted one this morning.
dme.
--
David Edmondson, http://dme.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.
2010-02-15 9:41 [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face David Edmondson
2010-02-15 10:03 ` David Edmondson
@ 2010-04-07 19:28 ` Carl Worth
1 sibling, 0 replies; 5+ messages in thread
From: Carl Worth @ 2010-04-07 19:28 UTC (permalink / raw)
To: David Edmondson, notmuch
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
On Mon, 15 Feb 2010 09:41:49 +0000, David Edmondson <dme@dme.org> wrote:
> ---
> notmuch.el | 2 ++
Thanks, David.
I've pushed this now, (with the later fix from Sebastian applied).
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-04-07 19:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-15 9:41 [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face David Edmondson
2010-02-15 10:03 ` David Edmondson
2010-02-16 10:22 ` Michal Sojka
2010-02-16 10:53 ` David Edmondson
2010-04-07 19:28 ` Carl Worth
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).