From: Carl Worth <cworth@cworth.org>
To: Austin Clements <amdragon@mit.edu>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] Fetch all message metadata in a single pass
Date: Mon, 25 Apr 2011 13:52:04 -0700 [thread overview]
Message-ID: <87oc3u3vgr.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <AANLkTi=uZXTacQFiUUk8k5h17NrV1wTo5OR7T=3UguE_@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]
On Mon, 21 Mar 2011 02:56:05 -0400, Austin Clements <amdragon@mit.edu> wrote:
> Thanks for the thorough review. My updated patches are on the
> eager-metadata-v4 branch (also, for-review/eager-metadata-v4) at
> http://awakening.csail.mit.edu/git/notmuch.git
Great. I failed at my commitment to quickly apply the updated series. I
want to do it now, but I'm failing to be able to fetch the code:
$ git fetch amdragon
error: RPC failed; result=22, HTTP code = 417
fatal: The remote end hung up unexpectedly
(This is using the URL above.)
> This doesn't cause any problems in the one weird case that still needs
> the reference to the list. After the _notmuch_tags_create, the caller
> simply adds that reference.
This, (and the other comments you made about the cleanup), all sound
great to me. So I'm looking forward to seeing the code.
> Heh, fixed. I suppose I hadn't been thinking about it, since none of
> the source in lib/ has other authors listed.
>
> But it raises an interesting question. When is it kosher to add
> oneself to a file's author list? In this case I wrote about half of
> the code in that admittedly short file, so that makes sense Changing
> a few lines presumably isn't enough. Adding a few functions?
My intention is simply to leave this up to the author of the code in
question. If you feel your name belongs on the author list, then please
put it there.
Similarly, if you think your code is sufficient to deserve copyright
protection, (so probably anything beyond simple typo fixes or otherwise
tiny changes), then *please* add your name (or your employer's name as
appropriate) to that list as well.
A quick check with grep shows that I've definitely not been asking for
this attribution as much as I should have. Hopefully we can all get in a
better habit going forward.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2011-04-25 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 20:59 [PATCH 0/5] Fetch all message metadata in a single pass Austin Clements
2010-12-09 20:59 ` [PATCH 1/5] Use a single unified pass to fetch scalar message metadata Austin Clements
2010-12-09 20:59 ` [PATCH 2/5] Implement an internal generic string list and use it Austin Clements
2010-12-23 2:44 ` Austin Clements
2010-12-09 20:59 ` [PATCH 3/5] Add a generic function to get a list of terms with some prefix Austin Clements
2010-12-09 20:59 ` [PATCH 4/5] Add the file name list to the unified message metadata pass Austin Clements
2010-12-09 20:59 ` [PATCH 5/5] Add the tag " Austin Clements
2011-02-13 20:25 ` [PATCH 0/5] Fetch all message metadata in a single pass Austin Clements
2011-03-11 3:48 ` Carl Worth
2011-03-21 6:56 ` Austin Clements
2011-04-25 20:52 ` Carl Worth [this message]
2011-04-25 21:42 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oc3u3vgr.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).