unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Thomas Schwinge <thomas@schwinge.name>
Cc: notmuch@notmuchmail.org
Subject: Re:
Date: Sun, 16 Oct 2011 20:25:38 -0300	[thread overview]
Message-ID: <87obxgbjt9.fsf@zancas.localnet> (raw)
In-Reply-To: <87ipno1xre.fsf@kepler.schwinge.homeip.net>

On Sun, 16 Oct 2011 22:34:29 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:

> Having worked in the same area ;-), I felt competent to review this.  And
> I definitely do like David's approach.  The patches look good, with the
> following comments:

Thanks for the review.  I pushed a modified version of the series which
I think fixed all of the things you noticed.

d

  reply	other threads:[~2011-10-16 23:25 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07  0:20 output file argument to notmuch dump David Bremner
2011-10-07  0:37 ` Dmitry Kurochkin
2011-10-07  0:53   ` David Bremner
2011-10-07  1:43     ` Tom Prince
2011-10-07  1:14 ` Jameson Graef Rollins
2011-10-07 10:23 ` Jesse Rosenthal
2011-10-07 11:15   ` Tomi Ollila
2011-10-07 17:22     ` Jameson Graef Rollins
2011-10-10  7:32       ` Tomi Ollila
2011-10-09 16:01 ` David Bremner
2011-10-10 13:49   ` david
2011-10-10 13:49     ` [PATCH 1/6] test: update dump-restore to use redirection instead of filename args david
2011-10-10 13:49     ` [PATCH 2/6] test: add tests for command line arguments to notmuch-dump david
2011-10-10 13:49     ` [PATCH 3/6] notmuch-dump: update handling of file name argument david
2011-10-10 13:49     ` [PATCH 4/6] notmuch-dump: treat any remaining arguments after the filename as search terms david
2011-10-10 13:49     ` [PATCH 5/6] test: all dump-restore tests should be working now david
2011-10-10 13:49     ` [PATCH 6/6] notmuch-dump: deprecate use of output file argument david
2011-10-16 20:34     ` Thomas Schwinge
2011-10-16 23:25       ` David Bremner [this message]
2011-10-10 13:59   ` output file argument to notmuch dump Tomi Ollila
2011-10-10 14:25     ` David Bremner
2011-10-10 16:41   ` Jameson Graef Rollins
2011-10-11  2:12     ` David Bremner
  -- strict thread matches above, loose matches on Subject: below --
2012-01-23  8:33 show-mode message/thread archiving improvements Jameson Graef Rollins
2012-01-25  0:06 ` Jameson Graef Rollins
2012-01-31  3:28   ` David Bremner
2012-02-01  2:49 emacs: quote MML tags in replies Dmitry Kurochkin
2012-02-02  4:01 ` David Bremner
2012-02-03 10:22   ` Pieter Praet
2012-12-11  9:00 Damien Cassou
2012-12-13 11:45 ` Mark Walters
2013-01-16 12:44 david
2013-01-17 10:36 ` David Bremner
2013-02-25 20:44 Martin Owens
2013-02-25 21:02 ` David Bremner
2014-01-19 18:57 [RFC Patch] start of sphinx based docs David Bremner
2014-01-28 16:12 ` David Bremner
2014-01-28 22:54   ` Mark Walters
2014-01-29  2:26     ` Re: David Bremner
2014-03-11 18:16 v2 man page build fixups Tomi Ollila
2014-03-13  3:21 ` David Bremner
2014-03-17 10:55   ` Tomi Ollila
2014-03-18 10:52   ` Re: David Bremner
2014-05-06 13:06 David Bremner
2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
2014-10-03 21:18 David Bremner
2014-10-03 21:22 ` David Bremner
2014-10-16 21:14 ` Re: Jani Nikula
2015-01-25 17:58 [PATCH 1/3] doc: add details about Xapian search syntax David Bremner
2015-02-23 20:05 ` David Bremner
2015-02-24  7:32   ` David Bremner
2016-10-11 21:24 matt
2016-10-12  7:51 ` Mark Walters
2016-10-15  7:09   ` Re: Mark Walters
2016-10-17 12:01 ` Re: David Bremner
2016-10-13 19:37 Matt Armstrong
2016-10-13 19:42 ` Matt Armstrong
2016-10-15  8:44 Re: Matthew Lear
2017-05-23 18:54 Tomi Ollila
2017-05-26 10:40 ` David Bremner
2017-06-11 11:00 [PATCH] Add Emacs' imenu support in notmuch-show and notmuch-search David Bremner
2017-06-12 13:30 ` Damien Cassou
2017-06-14  1:22   ` David Bremner
2017-06-14  9:44     ` Re: David Bremner
2017-06-14  9:54       ` Re: Damien Cassou
2018-02-01 20:53 Matthew Lear
2018-02-03 22:38 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obxgbjt9.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=thomas@schwinge.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).