From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Thomas Schwinge <thomas@schwinge.name>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".
Date: Tue, 18 Oct 2011 08:16:12 -0700 [thread overview]
Message-ID: <87obxee3er.fsf@servo.finestructure.net> (raw)
In-Reply-To: <87ehykflzw.fsf@kepler.schwinge.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
On Tue, 11 Oct 2011 01:46:43 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:
> On Sun, 9 Oct 2011 15:35:48 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > (defun notmuch-show-get-message-id ()
> > "Return the message id of the current message."
> > - (concat "id:\"" (notmuch-show-get-prop :id) "\""))
> > + (concat "\"" (notmuch-show-get-prop :id) "\""))
>
> Shouldn't the double quotes be removed here, too? (And be re-added in
> the other places where id: is added.)
Yes, I think you're right Thomas. Afaik emacs doesn't need any kind of
escaping when storing strings internally. I'll tweak that and resubmit
the patch.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2011-10-18 15:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <id:87ipnzd4ds.fsf@zancas.localnet>
2011-10-09 3:47 ` [PATCH] NEWS: add notes about emacs improvements and reply formating cleanup Jameson Graef Rollins
2011-10-09 3:55 ` Jameson Graef Rollins
2011-10-09 17:54 ` Thomas Schwinge
2011-10-09 22:35 ` Jameson Graef Rollins
2011-10-09 22:35 ` [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:" Jameson Graef Rollins
2011-10-10 23:46 ` Thomas Schwinge
2011-10-18 15:16 ` Jameson Graef Rollins [this message]
2011-10-27 2:52 ` Jameson Graef Rollins
2011-10-27 13:52 ` Tomi Ollila
2011-10-28 11:06 ` Daniel Schoepe
2011-10-28 11:21 ` Tomi Ollila
2011-11-12 14:52 ` David Bremner
2011-11-12 21:42 ` Jameson Graef Rollins
2011-10-09 11:31 ` [PATCH] NEWS: add notes about emacs improvements and reply formating cleanup David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obxee3er.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).