From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4EB67431FD0 for ; Mon, 31 Oct 2011 15:08:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EWs+5uph38Qw for ; Mon, 31 Oct 2011 15:08:05 -0700 (PDT) Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9E29C431FB6 for ; Mon, 31 Oct 2011 15:08:05 -0700 (PDT) Received: by faai28 with SMTP id i28so6781851faa.26 for ; Mon, 31 Oct 2011 15:08:04 -0700 (PDT) Received: by 10.223.14.3 with SMTP id e3mr32907327faa.25.1320098884201; Mon, 31 Oct 2011 15:08:04 -0700 (PDT) Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi. [80.220.92.23]) by mx.google.com with ESMTPS id j5sm40493434faf.14.2011.10.31.15.08.01 (version=SSLv3 cipher=OTHER); Mon, 31 Oct 2011 15:08:03 -0700 (PDT) From: Jani Nikula To: Jameson Graef Rollins , notmuch@notmuchmail.org Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results In-Reply-To: <87fwi86dky.fsf@servo.finestructure.net> References: <87fwi86dky.fsf@servo.finestructure.net> User-Agent: Notmuch/0.9+44~ga312b1d (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Tue, 01 Nov 2011 00:07:59 +0200 Message-ID: <87obwwlsqo.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: amdragon@mit.edu X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2011 22:08:06 -0000 On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins wrote: > Hi, Jani. Thanks for working on this. This should also be valuable for > vim users. Thanks for your interest! :) > In order to push forward with this, though, I think we really need to > have a complete unit test for this new functionality. We usually like > to see units tests that describe and then test for the new functionality > you wish to add, followed by the patches that provide the new > functionality. Lots of good tests for new functionality being proposed > here shouldn't be too difficult to work out ahead of time. Right. I'd just like to make sure the approach I've taken (particularly patch 1 in the set as it touches the lib) is acceptable before spending time on testing and documentation etc. Indeed patches 1 and 2 changed fundamentally between v1 and v2 after some chats on IRC. If the comments now are favourable, I'll write the tests and documentation. (Though I guess I have to admit the tests would've been beneficial to me already now...) BR, Jani.