* [PATCH] test: Remove #! line from test-lib.sh
@ 2011-12-29 2:34 Austin Clements
2011-12-29 4:56 ` Tomi Ollila
2011-12-29 22:06 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Austin Clements @ 2011-12-29 2:34 UTC (permalink / raw)
To: notmuch
It makes no sense to run test-lib.sh, so it makes no sense to give it
an interpreter. This is particularly annoying for Emacs users who
have executable-insert set, since the presence of the #! line will
cause Emacs to mark test-lib.sh executable when saving it, which will
in turn case the 'basic' test to fail.
---
test/test-lib.sh | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 862095c..82767c0 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -1,4 +1,3 @@
-#!/usr/bin/env bash
#
# Copyright (c) 2005 Junio C Hamano
#
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: Remove #! line from test-lib.sh
2011-12-29 2:34 [PATCH] test: Remove #! line from test-lib.sh Austin Clements
@ 2011-12-29 4:56 ` Tomi Ollila
2011-12-29 22:06 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2011-12-29 4:56 UTC (permalink / raw)
To: Austin Clements, notmuch
On Wed, 28 Dec 2011 21:34:56 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> It makes no sense to run test-lib.sh, so it makes no sense to give it
> an interpreter. This is particularly annoying for Emacs users who
> have executable-insert set, since the presence of the #! line will
> cause Emacs to mark test-lib.sh executable when saving it, which will
> in turn case the 'basic' test to fail.
> ---
> test/test-lib.sh | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
+1 !
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: Remove #! line from test-lib.sh
2011-12-29 2:34 [PATCH] test: Remove #! line from test-lib.sh Austin Clements
2011-12-29 4:56 ` Tomi Ollila
@ 2011-12-29 22:06 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2011-12-29 22:06 UTC (permalink / raw)
To: Austin Clements, notmuch
On Wed, 28 Dec 2011 21:34:56 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> It makes no sense to run test-lib.sh, so it makes no sense to give it
> an interpreter. This is particularly annoying for Emacs users who
> have executable-insert set, since the presence of the #! line will
> cause Emacs to mark test-lib.sh executable when saving it, which will
> in turn case the 'basic' test to fail.
Pushed.
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-29 22:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-29 2:34 [PATCH] test: Remove #! line from test-lib.sh Austin Clements
2011-12-29 4:56 ` Tomi Ollila
2011-12-29 22:06 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).