From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 9E612431FAF for ; Fri, 3 Feb 2012 22:12:14 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mQN9yDOGe07E for ; Fri, 3 Feb 2012 22:12:14 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B0705431FAE for ; Fri, 3 Feb 2012 22:12:13 -0800 (PST) Received: by bke11 with SMTP id 11so4097351bke.26 for ; Fri, 03 Feb 2012 22:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type:content-transfer-encoding; bh=pY1DfEV71xcyzBocBqO/60M7/nslxIo5zPkwH/0k5o8=; b=VpfJz4ijjVdHWlThMjDJ2hafhiCHA8wcbPuGrecp1V6C/0xXqfsFUo1Mwf5fK2C/H5 heTGinbLwAW08k0cL28Zvl8I05CxNH7jP+WyrZUfbz5zLCjC9Nbx2GWhd/PTtE1zdaGf YoxLRjv9ZHvVW7jzLj/3jY6aiU5f6seKTCOm4= Received: by 10.204.157.17 with SMTP id z17mr4731923bkw.37.1328335931023; Fri, 03 Feb 2012 22:12:11 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id ek9sm23291155bkb.10.2012.02.03.22.12.10 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Feb 2012 22:12:10 -0800 (PST) From: Dmitry Kurochkin To: Adam Wolfe Gordon , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] Bug and potential fix: forwarded messages In-Reply-To: References: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca> User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 04 Feb 2012 10:10:55 +0400 Message-ID: <87obtfi0wg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2012 06:12:14 -0000 On Fri, 3 Feb 2012 23:01:23 -0700, Adam Wolfe Gordon w= rote: > Oh, and I just noticed that Dmitry has already fixed this, probably in > a better way [1] (though I maintain that there still may be a problem > with the approach in general). I clearly haven't been following the > list closely enough this week. >=20 Yep, creating buttons for regions at the beginning of message is fixed. But I like the idea of not hiding the message if there is no text. Though, I think we should create the button, just not hide the text initially. This change would conflict with my fix, so we should probably wait until it is applied before working on this. Regards, Dmitry > [1] id:"1327926286-16680-1-git-send-email-dmitry.kurochkin@gmail.com" >=20 > On Fri, Feb 3, 2012 at 17:32, Adam Wolfe Gordon wrot= e: > > Hi everyone, > > > > I encountered today a bug that I remember being mentioned on IRC where > > some messages are shown in emacs as completely empty, even though their > > content is present and simple. For me, the bug shows up with messages t= hat > > have been forwarded by an Outlook user who didn't add any content to th= e top > > of the message. The first line of the message is "-----Original Message= -----", > > and the rest is the forwarded text. Notmuch tries to collapse the forwa= rded > > content into a button, but fails mysteriously. > > > > The first patch in this series adds a test (marked as broken) that demo= nstrates > > the bug. I think this should be pushed regardless of whether my solutio= n is > > the right one. My solution is to check whether we're collapsing the ent= ire > > message before doing so, and avoid turning it into a button if that's t= he case. > > I think this is a desirable behavior, since if someone has forwarded a = message > > without adding anything the user probably wants to read that message. B= ut, > > I'll admit that I didn't figure out the real cause of the problem, and I > > would be happy to hear other suggestions. > > > > It also occurs to me that this might indicate a bigger problem with how > > notmuch-wash.el handles messages starting with "-----Original Message--= ---". > > Notmuch seems to assume that this indicates the rest of the message is = quoted > > stuff that's been top-posted on. In my office this isn't necessarily th= e case, > > since Outlook produces that line at the top of every reply, and it's up= to > > the user whether to top-post or not (and not everyone does). > > > > I'll have to experiment a bit more to verify whether a problem (i.e. wh= ether > > Notmuch hides inappropriate things when someone replies inline with Out= look). > > Someone please correct me if I'm missing something in how the code oper= ates. > > > > Adam Wolfe Gordon (2): > > =C2=A0test: Add broken test for showing forwarded messages > > =C2=A0emacs: Fix broken showing of forwarded messages. > > > > =C2=A0emacs/notmuch-wash.el | =C2=A0 =C2=A05 +++-- > > =C2=A0test/emacs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 32 += +++++++++++++++++++++++++++++++ > > =C2=A02 files changed, 35 insertions(+), 2 deletions(-) > > > > -- > > 1.7.5.4 > > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch