From: Mark Walters <markwalters1009@gmail.com>
To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: make the command line parser's errors more informative.
Date: Tue, 05 Jun 2012 15:34:19 +0100 [thread overview]
Message-ID: <87oboxakus.fsf@qmul.ac.uk> (raw)
In-Reply-To: <20120605184037.GB14297@hili.localdomain>
On Tue, 05 Jun 2012, Peter Wang <novalazy@gmail.com> wrote:
> On Sun, 3 Jun 2012 12:48:48 +0100, Mark Walters <markwalters1009@gmail.com> wrote:
>>
>> +static notmuch_bool_t
>> +_process_int_arg (const notmuch_opt_desc_t *arg_desc, char next, const char *arg_str) {
>> +
>> + char *endptr;
>> + if (next == 0 || arg_str[0] == 0) {
>> + fprintf (stderr, "Option \"%s\" needs an integer argument.\n", arg_desc->name);
>> + return FALSE;
>> + }
>> +
>> + *((int *)arg_desc->output_var) = strtol (arg_str, &endptr, 10);
>> + if (*endptr == 0)
>> + return TRUE;
>
> It's usually clearer to write '\0' for the null character.
Yes I agree: fixed. I also changed the other instances.
>> @@ -99,20 +133,13 @@ parse_option (const char *arg,
>> char next = arg[strlen (try->name)];
>> const char *value= arg+strlen(try->name)+1;
>>
>> - char *endptr;
>> -
>> - /* Everything but boolean arguments (switches) needs a
>> - * delimiter, and a non-zero length value. Boolean
>> - * arguments may take an optional =true or =false value.
>> - */
>> - if (next != '=' && next != ':' && next != 0) return FALSE;
>> - if (next == 0) {
>> - if (try->opt_type != NOTMUCH_OPT_BOOLEAN &&
>> - try->opt_type != NOTMUCH_OPT_KEYWORD)
>> - return FALSE;
>> - } else {
>> - if (value[0] == 0) return FALSE;
>> - }
>> + /* If this is not the end of the argument (i.e. the next
>> + * character is not a space or a delimiter) we stop
>> + * parsing for this option but allow the parsing to
>> + * continue to for other options. This should allow
>> + * options to be initial segments of other options. */
>
> It took me a little while to figure out what the last sentence was
> about. Perhaps:
>
> If we have not reached the end of the argument (i.e. the next
> character is not a space or delimiter) then the argument could
> still match a longer option name later in the option table.
This is much clearer, thanks!
> (otherwise, "continue to for other")
>
>> + if (next != '=' && next != ':' && next != 0)
>> + goto DONE_THIS_OPTION;
>
> The `goto' could be expressed as a `continue' in a `for' loop, AFAICS.
This is also much nicer. Updated patch follows
Thanks for the review!
Best wishes
Mark
next prev parent reply other threads:[~2012-06-05 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 11:46 [Patch v7 0/6] Allow JSON to use non-entire thread, and use for elide Mark Walters
2012-06-03 11:46 ` [Patch v7 1/6] cli: command line parsing: allow default for keyword options Mark Walters
2012-06-03 11:46 ` [Patch v7 2/6] cli: Let json output "null" messages for non --entire-thread Mark Walters
2012-06-03 11:46 ` [Patch v7 3/6] cli: make --entire-thread=false work for format=json Mark Walters
2012-06-03 11:46 ` [Patch v7 4/6] Update devel/schemata for --entire-thread=false Mark Walters
2012-06-03 11:46 ` [Patch v7 5/6] emacs: make elide messages use notmuch-show for omitting messages Mark Walters
2012-06-03 11:46 ` [Patch v7 6/6] cli: notmuch-show.c fix whitespace error Mark Walters
2012-06-03 11:48 ` [PATCH] cli: make the command line parser's errors more informative Mark Walters
2012-06-05 8:40 ` Peter Wang
2012-06-05 14:34 ` Mark Walters [this message]
2012-06-05 14:36 ` [PATCH v2] " Mark Walters
2012-09-02 2:35 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oboxakus.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=novalazy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).