* [PATCH] emacs: show: exclude bug fix
@ 2012-07-28 11:56 Mark Walters
2012-07-28 16:31 ` Jameson Graef Rollins
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mark Walters @ 2012-07-28 11:56 UTC (permalink / raw)
To: notmuch
The pipe message function (when used with a prefix) uses a search of
the form "id:<id1> or id:<id2>" etc. Since the user says precisely
which messages are wanted by opening them it should not use excludes.
---
This is a small bugfix. Note that emacs how mode includes excluded
messages in its buffer but, by default, it displays them closed.
emacs/notmuch-show.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 6335d45..dcfc190 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1617,7 +1617,7 @@ than only the current message."
(let (shell-command)
(if entire-thread
(setq shell-command
- (concat notmuch-command " show --format=mbox "
+ (concat notmuch-command " show --format=mbox --exclude=false "
(shell-quote-argument
(mapconcat 'identity (notmuch-show-get-message-ids-for-open-messages) " OR "))
" | " command))
--
1.7.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: show: exclude bug fix
2012-07-28 11:56 [PATCH] emacs: show: exclude bug fix Mark Walters
@ 2012-07-28 16:31 ` Jameson Graef Rollins
2012-07-31 7:48 ` Tomi Ollila
2012-08-03 1:00 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: Jameson Graef Rollins @ 2012-07-28 16:31 UTC (permalink / raw)
To: Mark Walters, notmuch
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Sat, Jul 28 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> The pipe message function (when used with a prefix) uses a search of
> the form "id:<id1> or id:<id2>" etc. Since the user says precisely
> which messages are wanted by opening them it should not use excludes.
> ---
>
> This is a small bugfix. Note that emacs how mode includes excluded
> messages in its buffer but, by default, it displays them closed.
LGTM.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: show: exclude bug fix
2012-07-28 11:56 [PATCH] emacs: show: exclude bug fix Mark Walters
2012-07-28 16:31 ` Jameson Graef Rollins
@ 2012-07-31 7:48 ` Tomi Ollila
2012-08-03 1:00 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Ollila @ 2012-07-31 7:48 UTC (permalink / raw)
To: Mark Walters, notmuch
On Sat, Jul 28 2012, Mark Walters wrote:
> The pipe message function (when used with a prefix) uses a search of
> the form "id:<id1> or id:<id2>" etc. Since the user says precisely
> which messages are wanted by opening them it should not use excludes.
> ---
>
> This is a small bugfix. Note that emacs how mode includes excluded
> messages in its buffer but, by default, it displays them closed.
LGTM.
Tomi
>
> emacs/notmuch-show.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 6335d45..dcfc190 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1617,7 +1617,7 @@ than only the current message."
> (let (shell-command)
> (if entire-thread
> (setq shell-command
> - (concat notmuch-command " show --format=mbox "
> + (concat notmuch-command " show --format=mbox --exclude=false "
> (shell-quote-argument
> (mapconcat 'identity (notmuch-show-get-message-ids-for-open-messages) " OR "))
> " | " command))
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: show: exclude bug fix
2012-07-28 11:56 [PATCH] emacs: show: exclude bug fix Mark Walters
2012-07-28 16:31 ` Jameson Graef Rollins
2012-07-31 7:48 ` Tomi Ollila
@ 2012-08-03 1:00 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2012-08-03 1:00 UTC (permalink / raw)
To: Mark Walters, notmuch
Mark Walters <markwalters1009@gmail.com> writes:
> The pipe message function (when used with a prefix) uses a search of
> the form "id:<id1> or id:<id2>" etc. Since the user says precisely
> which messages are wanted by opening them it should not use excludes.
Pushed,
d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-03 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-28 11:56 [PATCH] emacs: show: exclude bug fix Mark Walters
2012-07-28 16:31 ` Jameson Graef Rollins
2012-07-31 7:48 ` Tomi Ollila
2012-08-03 1:00 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).