From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>,
Austin Clements <amdragon@MIT.EDU>,
Ben Gamari <bgamari.foss@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] sprinters: bugfix when NULL passed for a string.
Date: Wed, 08 Aug 2012 09:25:49 -0700 [thread overview]
Message-ID: <87obmlic4y.fsf@servo.finestructure.net> (raw)
In-Reply-To: <878vdp3knf.fsf@qmul.ac.uk>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Wed, Aug 08 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> For the From/Date headers see http://www.ietf.org/rfc/rfc2822.txt
> section 3.6 for details:
>
> The only required header fields are the origination date field and
> the originator address field(s). All other header fields are
> syntactically optional.
>
> and origination date field means a Date: header, and originator
> address field means a From: header. However, I don't think an empty
> string is valid for either of these so we can't sensibly output
> something standards compliant. Thus I would go for following the
> original message and omit any fields not present in it.
I agree. Let's not pretend or imply something is valid when it's not.
The output should reflect the actual content of the message as much as
possible.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-08-08 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 5:52 Segmentation fault in notmuch search --format=json Ben Gamari
2012-08-07 7:07 ` Mark Walters
2012-08-07 8:08 ` Jameson Graef Rollins
2012-08-07 12:49 ` Austin Clements
2012-08-07 19:48 ` [PATCH] sprinters: bugfix when NULL passed for a string Mark Walters
2012-08-08 1:36 ` Jameson Graef Rollins
2012-08-08 2:09 ` Austin Clements
2012-08-08 7:31 ` Mark Walters
2012-08-08 16:25 ` Jameson Graef Rollins [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-07 21:21 [PATCH] test: Add test for messages with missing headers Austin Clements
2012-08-08 1:28 ` [PATCH v2] " Austin Clements
2012-08-08 21:23 ` [PATCH] sprinters: bugfix when NULL passed for a string Mark Walters
2012-08-08 21:28 ` Austin Clements
2012-08-12 19:51 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obmlic4y.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=amdragon@MIT.EDU \
--cc=bgamari.foss@gmail.com \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).