From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 090F7431FB6 for ; Mon, 15 Oct 2012 19:59:33 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OlGUaz7N8gRP for ; Mon, 15 Oct 2012 19:59:31 -0700 (PDT) Received: from mail-qa0-f53.google.com (mail-qa0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 1BE3C431FAE for ; Mon, 15 Oct 2012 19:59:30 -0700 (PDT) Received: by mail-qa0-f53.google.com with SMTP id s11so2262510qaa.5 for ; Mon, 15 Oct 2012 19:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=oPEb/8JMIqa3O8onKXfxJmplVhTbnTez/SM91WVbxUo=; b=NTxkFMyLLoF6Vi1l7R4LQ5d1QL2Qc6rz3zBkbq6mXJONgZ8IjWvD0qCaha2P2g4I5d xs0i47Zmum/vSuz29DC6bCG8xqpVjcz64pc3qbjKzhgo1iK1LNp850H53jLwCGAEQDLw gzTK2N/Hswjyz21LufhGzkMME63wcQ8TGk70deAV2fIyQuhyGselgMF0I1lylU/LPhpC fhdPH5Wt+aA7TGjS3GbcZ4dDmWPVsB7XY6CTM3WXYXX2tz11djTuCMjByzgLXY1M3swF II+1ZtMEgmfIZtqJoSqlpU7CuvYOi4azayYzSM2CXGykMsJON5flO2qICL1KjQ3KCt3P uquA== Received: by 10.229.106.14 with SMTP id v14mr1670541qco.85.1350356370499; Mon, 15 Oct 2012 19:59:30 -0700 (PDT) Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) by mx.google.com with ESMTPS id cz8sm11525132qab.21.2012.10.15.19.59.28 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Oct 2012 19:59:29 -0700 (PDT) From: Ethan Glasser-Camp To: Mark Walters , Pieter Praet , David Bremner , Dmitry Kurochkin Subject: Re: [PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc' In-Reply-To: <87vclywxek.fsf@qmul.ac.uk> References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca> <1330122640-18895-1-git-send-email-pieter@praet.org> <1330122640-18895-5-git-send-email-pieter@praet.org> <87vclywxek.fsf@qmul.ac.uk> User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 15 Oct 2012 22:59:27 -0400 Message-ID: <87obk386ls.fsf@betacantrips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2012 02:59:33 -0000 Mark Walters writes: > The original function feels a little fragile to me as to what happens if > predicate or function move point. Eg what happens if function collapses > the message: where does point go, and so where does > notmuch-show-goto-message-next go. Is this just my naivete as a lisp > beginner? Is there someway of writing it so the user doesn't need to > worry about such things? Although collapsing the message doesn't seem to move point, it would probably be a good idea to wrap the calls to predicate and function in save-excursion, as a guard against subtle and hard-to-spot bugs with operations not being applied to all the right messages.. Ethan