From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7B759431FAF for ; Wed, 24 Oct 2012 03:52:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8NlMkHxu9fFw for ; Wed, 24 Oct 2012 03:52:16 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4182E431FAE for ; Wed, 24 Oct 2012 03:52:16 -0700 (PDT) Received: by mail-la0-f53.google.com with SMTP id l5so248024lah.26 for ; Wed, 24 Oct 2012 03:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=YdCFgqrIH6tZohZmmxGkpxbYtifouqfYT2TtG0qb8v8=; b=bewAMxh7ZqNcqXUQEAFUoaZD9UMqOTv3FD5scKbz5Y8Livb4zs9UfuAviNTI0rhvB2 XEarLpIOT2DAHUEnwQp8pRjxqgW1P/B/AaJYNMZoVDF1i2AhqTtTFtdZD5RSpXr93r2y gKry5tfxrkhrXSL4vRyNnfC3pKdjmoAYNglDN9J7Cd/O3rBqAYlrDjvbR5O+fDkPoLHX 8VB3JuWX+Bb4qJaK5E45EVb1hGYcAoQASAK+aAx5kR5SnvXqk1GjPtwsKLUgE7yCAjpu pjh+xcw35u76m43P88ymuQo7rOffBUysEzGZvcap8VaDpvkA9toRwLR7SRLbfGbMm+xL /y4w== Received: by 10.112.46.35 with SMTP id s3mr6068599lbm.88.1351075934505; Wed, 24 Oct 2012 03:52:14 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id h8sm4891445lbk.0.2012.10.24.03.52.13 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Oct 2012 03:52:13 -0700 (PDT) From: Dmitry Kurochkin To: Damien Cassou , David Bremner Subject: Re: [ANN] notmuch-labeler: Improves notmuch way of displaying labels In-Reply-To: References: <87lifbmxfg.fsf@maritornes.cs.unb.ca> User-Agent: Notmuch/0.14+52~gdf2c274 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Wed, 24 Oct 2012 14:52:12 +0400 Message-ID: <87objs87mr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2012 10:52:18 -0000 Hi Damien. Damien Cassou writes: > Hi, > > On Fri, Oct 12, 2012 at 7:07 PM, David Bremner wrote: >> It seeems like a nice UI enchancement, and people would not have to use >> it if they didn't like it, so in principle I guess we should work >> towards integrating it into notmuch upstream. > > > does anyone else agrees? Should I spend time on that or does nobody care? > I do agree! Would be nice to have this feature integrated into notmuch. Regards, Dmitry > >> I'm not an elisp expert, but I did find it strange to use use defadvice >> on your own code. Maybe I'm just too conservative. > > > I let myself advise my own code only when no duplication is involved > and when the dependencies between the modules that contain the > function and its pieces of advice are well defined. I have no problem > using a different mechanism (such a function variable and calling > funcall) if integration into notmuch is desired but not defadvice. > > >> At some point we should probably get a patch series against notmuch >> mainline; I'll let other people comment on whether yes, now is the time >> (and thereby volunteering to review the patches ;). > > Anyone interested in notmuch-labeler? > https://github.com/DamienCassou/notmuch-labeler (there are screenshots > there) > > -- > Damien Cassou > http://damiencassou.seasidehosting.st > > "Success is the ability to go from one failure to another without > losing enthusiasm." > Winston Churchill > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch