[PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy

[PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy

[Tomi Ollila]

Check that the underlining '===...' for first (header) line in NEWS
file is of the same length as the header text and it is all '=':s.
---
 devel/release-checks.sh | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/devel/release-checks.sh b/devel/release-checks.sh
index d2bbc6a..c13758a 100755
--- a/devel/release-checks.sh
+++ b/devel/release-checks.sh
@@ -104,6 +104,20 @@ else
 	append_emsg "Version '$py_version' is not '$VERSION' in $PV_FILE"
 fi
 
+echo -n "Checking that NEWS header is tidy... "
+if [ "`exec sed 's/./=/g; 1q' NEWS`" = "`exec sed '1d; 2q' NEWS`" ]
+then
+	echo Yes.
+else
+	echo No.
+	if [ "`exec sed '1d; s/=//g; 2q' NEWS`" != '' ]
+	then
+		append_emsg "Line 2 in NEWS file is not all '=':s"
+	else
+		append_emsg "Line 2 in NEWS file does not have the same length as line 1"
+	fi
+fi
+
 echo -n "Checking that this is Notmuch NEWS... "
 read news_notmuch news_version news_date < NEWS
 if [ "$news_notmuch" = "Notmuch" ]
-- 
1.8.1

Re: [PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> +echo -n "Checking that NEWS header is tidy... "
> +if [ "`exec sed 's/./=/g; 1q' NEWS`" = "`exec sed '1d; 2q' NEWS`" ]

This patch seems OK to me, although the execs might be a bit overkill
for a script that is run once ever few months.

d

Re: [PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy

[Tomi Ollila]

On Sat, Feb 16 2013, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> +echo -n "Checking that NEWS header is tidy... "
>> +if [ "`exec sed 's/./=/g; 1q' NEWS`" = "`exec sed '1d; 2q' NEWS`" ]
>
> This patch seems OK to me, although the execs might be a bit overkill
> for a script that is run once ever few months.

You're right. The 2 extra fork(2):s(*) here doesn't matter...

In case you don't amend my patch in following weeks I'll send
a new patch :)

> d

(*) FYI: It is only bash(1) which forks process to execute the external
command in such a trivial cases. Most (if not all) other shells have
(conservative) heuristics to avoid the "extra" fork there. If you're
interested, my simple way to test this is 'strace -ff -o pidc cmd args...'

Tomi

Re: [PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Check that the underlining '===...' for first (header) line in NEWS
> file is of the same length as the header text and it is all '=':s.

pushed, sans execs

d