unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands
Date: Fri, 08 Mar 2013 08:05:33 -0400	[thread overview]
Message-ID: <87obeuaygi.fsf@zancas.localnet> (raw)
In-Reply-To: <75b8b04e4d63d67ec79ffe2379829add96b37be0.1362347362.git.jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:

> This allows specifying config file as a top level argument to notmuch,
> and generally makes it possible to override config file options in
> main(), without having to touch the subcommands.
>

I pushed patchs 5 through 7 of this 6 patch series.

- I'll see if I can figure out the elisp needed to work around the
  "Tramp stomped on my environment variables" problem.

- Is this NEWS worthy? 

- What about a unit test?

- What about updating the tests to use this feature, is that a good idea? 


d

  reply	other threads:[~2013-03-08 12:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-03 21:55 [PATCH v2 0/6] notmuch cli config changes Jani Nikula
2013-03-03 21:55 ` [PATCH v2 1/6] cli: abstract subcommand finding into a new function Jani Nikula
2013-03-03 21:55 ` [PATCH v2 2/6] cli: plug main notmuch command into subcommand machinery Jani Nikula
2013-03-03 21:55 ` [PATCH v2 3/6] cli: config: keep track of whether the config is newly created Jani Nikula
2013-03-03 21:55 ` [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only Jani Nikula
2013-03-07 13:44   ` David Bremner
2013-03-07 14:38     ` Tomi Ollila
2013-03-03 21:55 ` [PATCH v2 5/6] cli: move config open/close to main() from subcommands Jani Nikula
2013-03-08 12:05   ` David Bremner [this message]
2013-03-03 21:55 ` [PATCH v2 6/6] cli: add top level --config=FILE option Jani Nikula
2013-03-04 19:53 ` [PATCH] man: document the notmuch --config=FILE global option Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obeuaygi.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).