unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/3] contrib: pick: if no target specified go to first matching message
Date: Sun, 30 Jun 2013 13:05:59 -0300	[thread overview]
Message-ID: <87obantwgo.fsf@zancas.localnet> (raw)
In-Reply-To: <1372582512-10777-2-git-send-email-markwalters1009@gmail.com>

Mark Walters <markwalters1009@gmail.com> writes:
> -  (let ((msg-id (notmuch-id-to-query (plist-get msg :id))))
> -    (when (string= msg-id notmuch-pick-target-msg)
> +  (let ((msg-id (notmuch-id-to-query (plist-get msg :id)))
> +	(target notmuch-pick-target-msg))
> +    (when (or (and (not target) (plist-get msg :match))
> +	      (string= msg-id target))

I can't really figure out from looking at the code what this 'target'
business is about. Possibly unrelated to this patch, but maybe some
documentation is needed?

d

  reply	other threads:[~2013-06-30 16:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30  8:55 [PATCH v2 0/3] Contrib: Pick: Remove horrible hack Mark Walters
2013-06-30  8:55 ` [PATCH v2 1/3] contrib: pick: if no target specified go to first matching message Mark Walters
2013-06-30 16:05   ` David Bremner [this message]
2013-06-30  8:55 ` [PATCH v2 2/3] contrib: pick: remove hack notmuch-pick-show-match-message-with-wait Mark Walters
2013-06-30 16:30   ` David Bremner
2013-06-30 21:15     ` Mark Walters
2013-06-30 21:18       ` [PATCH] contrib: pick: add a docstring for the main notmuch-pick function Mark Walters
2013-07-01  3:07       ` [PATCH v2 2/3] contrib: pick: remove hack notmuch-pick-show-match-message-with-wait David Bremner
2013-06-30  8:55 ` [PATCH v2 3/3] contrib: pick: fix refresh result Mark Walters
2013-06-30 16:39   ` David Bremner
2013-07-04  3:48 ` [PATCH v2 0/3] Contrib: Pick: Remove horrible hack David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obantwgo.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).