From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 443A2431FBC for ; Tue, 23 Jul 2013 19:28:24 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8RtezQZbH6Ir for ; Tue, 23 Jul 2013 19:28:19 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8B88E431FB6 for ; Tue, 23 Jul 2013 19:28:19 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1V1ooI-000278-Rt; Tue, 23 Jul 2013 23:28:14 -0300 Received: (nullmailer pid 23197 invoked by uid 1000); Wed, 24 Jul 2013 02:28:11 -0000 From: David Bremner To: Mark Walters Subject: Re: [PATCH] emacs: hello: make --batch error gracefully In-Reply-To: <1372976299-30389-1-git-send-email-markwalters1009@gmail.com> References: <1372976299-30389-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Tue, 23 Jul 2013 23:28:11 -0300 Message-ID: <87ob9svghw.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain Cc: notmuch mailing list X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jul 2013 02:28:24 -0000 Mark Walters writes: > - (call-process-region (point-min) (point-max) notmuch-command > - t t nil "count" "--batch") > + (unless (= (call-process-region (point-min) (point-max) notmuch-command > + t t nil "count" "--batch") 0) > + (notmuch-logged-error "notmuch CLI version mismatch error (count --batch) > +The most likely cause of this error is that the CLI is too old > +to support count --batch and needs to be upgraded to the same > +version as notmuch-emacs")) > + I had a look at this, and I agree the current failure mode is not nice (it just says something mysterious about nil not being a string). On the other hand, I think we should use the two argument form of notmuch-logged-error, and the the first argument should say only what we know. Something like (notmuch-logged-error "notmuch count --batch failed" "notmuch count --batch failed Please check that the notmuch CLI is new enough to support `count --batch'. In general we recommend running matching versions of the CLI and emacs interface.") d