From: Jani Nikula <jani@nikula.org>
To: david@tethera.net, notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: Re: [PATCH] test: update insert tests for new maildir synchronization rules
Date: Tue, 03 Sep 2013 08:22:18 +0300 [thread overview]
Message-ID: <87ob8ao4xh.fsf@nikula.org> (raw)
In-Reply-To: <1378170613-3584-1-git-send-email-david@tethera.net>
On Tue, 03 Sep 2013, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> As of id:1355952747-27350-4-git-send-email-sojkam1@fel.cvut.cz
> we are more conservative about moving messages from ./new to ./cur.
> This updates the insert tests to match
> ---
>
> Hopefully this makes sense, and is not just papering over a real
> problem that should be fixed.
LGTM. I sent some additional tests on top.
Jani.
>
> test/insert | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/insert b/test/insert
> index 021edb6..1718120 100755
> --- a/test/insert
> +++ b/test/insert
> @@ -82,7 +82,7 @@ gen_insert_msg
> notmuch insert --folder=Drafts < "$gen_msg_filename"
> output=$(notmuch search --output=files folder:Drafts)
> dirname=$(dirname "$output")
> -test_expect_equal "$dirname" "$MAIL_DIR/Drafts/cur"
> +test_expect_equal "$dirname" "$MAIL_DIR/Drafts/new"
>
> test_begin_subtest "Insert message into folder, add/remove tags"
> gen_insert_msg
> @@ -99,14 +99,14 @@ gen_insert_msg
> notmuch insert --folder=F --create-folder +folder < "$gen_msg_filename"
> output=$(notmuch search --output=files folder:F tag:folder)
> basename=$(basename "$output")
> -test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/cur/${basename}"
> +test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/new/${basename}"
>
> test_begin_subtest "Insert message, create subfolder"
> gen_insert_msg
> notmuch insert --folder=F/G/H/I/J --create-folder +folder < "$gen_msg_filename"
> output=$(notmuch search --output=files folder:F/G/H/I/J tag:folder)
> basename=$(basename "$output")
> -test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/cur/${basename}"
> +test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/new/${basename}"
>
> test_begin_subtest "Insert message, create existing subfolder"
> gen_insert_msg
> --
> 1.8.3.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
--
Jani
next prev parent reply other threads:[~2013-09-03 5:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 21:32 [PATCH 0/3] Adding non-maildir tags does not move message from new to cur Michal Sojka
2012-12-19 21:32 ` [PATCH 1/3] test: " Michal Sojka
2013-09-03 23:56 ` David Bremner
2012-12-19 21:32 ` [PATCH 2/3] test: Add some missing maildir synchronization tests Michal Sojka
2012-12-19 21:32 ` [PATCH 3/3] tags_to_maildir_flags: Don't rename if no flags change Michal Sojka
2013-09-03 1:10 ` [PATCH] test: update insert tests for new maildir synchronization rules david
2013-09-03 5:19 ` [PATCH 1/2] test: add more maildir flag syncing related tests to insert Jani Nikula
2013-09-03 5:19 ` [PATCH 2/2] test: improve insert test reliability by checking message-id instead of count Jani Nikula
2013-09-03 9:26 ` [PATCH 1/2] test: add more maildir flag syncing related tests to insert David Bremner
2013-09-03 12:11 ` Jani Nikula
2013-09-03 5:22 ` Jani Nikula [this message]
2013-09-02 17:56 ` [PATCH 0/3] Adding non-maildir tags does not move message from new to cur Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob8ao4xh.fsf@nikula.org \
--to=jani@nikula.org \
--cc=bremner@debian.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).