[PATCH] contrib: pick: bugfix use of mini-buffer history

[PATCH] contrib: pick: bugfix use of mini-buffer history

[Mark Walters]

pick was meant to use the same mini-buffer history but this failed
because the interactive definition took place before the use search
mini-buffer history part. Remove the interactive prompt to ensure the
correct history is used.
---
 contrib/notmuch-pick/notmuch-pick.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 01ca4bd..ad85d03 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -948,7 +948,7 @@ The arguments are:
   BUFFER-NAME: the name of the buffer to show the pick tree. If
       it is nil \"*notmuch-pick\" followed by QUERY is used.
   OPEN-TARGET: If TRUE open the target message in the message pane."
-  (interactive "sNotmuch pick: ")
+  (interactive)
   (if (null query)
       (setq query (notmuch-read-query "Notmuch pick: ")))
   (let ((buffer (get-buffer-create (generate-new-buffer-name
-- 
1.7.9.1

Re: [PATCH] contrib: pick: bugfix use of mini-buffer history

[Tomi Ollila]

On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> pick was meant to use the same mini-buffer history but this failed
> because the interactive definition took place before the use search
> mini-buffer history part. Remove the interactive prompt to ensure the
> correct history is used.
> ---

LGTM.

Tomi

>  contrib/notmuch-pick/notmuch-pick.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 01ca4bd..ad85d03 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -948,7 +948,7 @@ The arguments are:
>    BUFFER-NAME: the name of the buffer to show the pick tree. If
>        it is nil \"*notmuch-pick\" followed by QUERY is used.
>    OPEN-TARGET: If TRUE open the target message in the message pane."
> -  (interactive "sNotmuch pick: ")
> +  (interactive)
>    (if (null query)
>        (setq query (notmuch-read-query "Notmuch pick: ")))
>    (let ((buffer (get-buffer-create (generate-new-buffer-name
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] contrib: pick: bugfix use of mini-buffer history

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> pick was meant to use the same mini-buffer history but this failed
> because the interactive definition took place before the use search
> mini-buffer history part. Remove the interactive prompt to ensure the
> correct history is used.

pushed.

d