From: Mark Walters <markwalters1009@gmail.com>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 00/10] "notmuch address" command
Date: Tue, 04 Nov 2014 09:23:42 +0000 [thread overview]
Message-ID: <87oasn2uap.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>
On Mon, 03 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> Hi all,
>
> this is v2 of "notmuch address" patchset. It obsoletes [1].
>
> Don't be scared by the number of patches. Most of them are trivial
> refactoring. Patches 1-4 refactor the code so that "notmuch search"
> command is easier to split. Patch 5 is Jani's hierarchical command
> line parsing patch. Patch 6 splits search functionality to new address
> command. Patch 7 is minor refactoring. Patches 8-10 correspond to
> patches 5-7 in the original "notmuch search
> --output=sender/recipients" patch series [2].
>
> Changes from v1:
>
> - Rebased to current master (conflicted with Jani's "notmuch search
> --duplicate=N with --output=messages" patch)
> - Fixed printing of false "Unrecognized option" error message in
> hierarchical command line parser.
Overall this series looks good. My inclination is to leave patch 10
until after the freeze but I am happy either way. Tests all work and my
testing is fine.
A couple of other comments:
you should add something to devel/schemata detailing the fields in the
structured address output.
Please check the new manpage: I think some of it is slightly outdated. I
mentioned in my comments the exclude=false, but missed exclude=all. Also
the manpage could say what actually gets printed in the default text
case (in particular to emphasise that it includes the real name)
Best wishes
Mark
>
> Regards,
> -Michal
>
> [1] id:1414889400-30977-1-git-send-email-sojkam1@fel.cvut.cz
> [2] id:1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz
>
>
> Jani Nikula (1):
> cli: add support for hierarchical command line option arrays
>
> Michal Sojka (9):
> cli: search: Rename options to context
> cli: search: Move more variables into search_context_t
> cli: search: Convert ctx. to ctx->
> cli: search: Split notmuch_search_command to smaller functions
> cli: Introduce "notmuch address" command
> cli: search: Convert --output to keyword argument
> cli: address: Do not output duplicate addresses
> cli: address: Add --output=count
> cli: address: Add --filter-by option to configure address filtering
>
> command-line-arguments.c | 16 +-
> command-line-arguments.h | 1 +
> completion/notmuch-completion.bash | 48 +++-
> completion/notmuch-completion.zsh | 11 +-
> doc/man1/notmuch-address.rst | 140 ++++++++++++
> doc/man1/notmuch-search.rst | 21 +-
> doc/man1/notmuch.rst | 7 +-
> notmuch-client.h | 3 +
> notmuch-search.c | 454 +++++++++++++++++++++++++------------
> notmuch.c | 2 +
> test/T095-address.sh | 148 ++++++++++++
> test/T097-address-filter-by.sh | 73 ++++++
> 12 files changed, 751 insertions(+), 173 deletions(-)
> create mode 100644 doc/man1/notmuch-address.rst
> create mode 100755 test/T095-address.sh
> create mode 100755 test/T097-address-filter-by.sh
>
> --
> 2.1.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-11-04 9:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 23:50 [PATCH v2 00/10] "notmuch address" command Michal Sojka
2014-11-03 23:50 ` [PATCH v2 01/10] cli: search: Rename options to context Michal Sojka
2014-11-04 6:24 ` David Bremner
2014-11-03 23:50 ` [PATCH v2 02/10] cli: search: Move more variables into search_context_t Michal Sojka
2014-11-03 23:50 ` [PATCH v2 03/10] cli: search: Convert ctx. to ctx-> Michal Sojka
2014-11-04 6:29 ` David Bremner
2014-11-03 23:50 ` [PATCH v2 04/10] cli: search: Split notmuch_search_command to smaller functions Michal Sojka
2014-11-03 23:50 ` [PATCH v2 05/10] cli: add support for hierarchical command line option arrays Michal Sojka
2014-11-04 6:36 ` David Bremner
2014-11-04 6:38 ` David Bremner
2014-11-03 23:50 ` [PATCH v2 06/10] cli: Introduce "notmuch address" command Michal Sojka
2014-11-04 6:52 ` David Bremner
2014-11-04 9:40 ` Tomi Ollila
2014-11-04 21:59 ` Michal Sojka
2014-11-04 22:12 ` David Bremner
2014-11-04 9:04 ` Mark Walters
2014-11-04 22:15 ` Michal Sojka
2014-11-05 11:22 ` Mark Walters
2014-11-05 12:23 ` Michal Sojka
2014-11-05 12:48 ` Mark Walters
2014-11-03 23:50 ` [PATCH v2 07/10] cli: search: Convert --output to keyword argument Michal Sojka
2014-11-04 8:58 ` Mark Walters
2014-11-04 9:08 ` Mark Walters
2014-11-04 11:26 ` Michal Sojka
2014-11-03 23:50 ` [PATCH v2 08/10] cli: address: Do not output duplicate addresses Michal Sojka
2014-11-04 7:05 ` David Bremner
2014-11-04 11:36 ` Michal Sojka
2014-11-03 23:50 ` [PATCH v2 09/10] cli: address: Add --output=count Michal Sojka
2014-11-04 9:11 ` Mark Walters
2014-11-03 23:50 ` [PATCH v2 10/10] cli: address: Add --filter-by option to configure address filtering Michal Sojka
2014-11-04 9:23 ` Mark Walters [this message]
2014-11-04 20:33 ` [PATCH v2 00/10] "notmuch address" command Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oasn2uap.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).